[RFC,v2,22/26] libcamera: software_isp: egl: Move scaling to the second stage
diff mbox series

Message ID 20261118095735.170587-23-bryan.odonoghue@linaro.org
State New
Headers show
Series
  • gpuisp multipass + fixes
Related show

Commit Message

Bryan O'Donoghue Nov. 18, 2026, 9:57 a.m. UTC
If we scale in the blc/normalise pass when we write to the output buffer we
will be dropping Bayer encoded data.

OTOH if we scale at the output of the demosaic phase the data we end up
dropping has already been interpolated into RGB.

Dropping at the BLC phase means losing the data-source to properly
interpolate.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 src/libcamera/software_isp/software_isp_instance_gpu.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Patch
diff mbox series

diff --git a/src/libcamera/software_isp/software_isp_instance_gpu.cpp b/src/libcamera/software_isp/software_isp_instance_gpu.cpp
index 13d27ab7a..31940bdc6 100644
--- a/src/libcamera/software_isp/software_isp_instance_gpu.cpp
+++ b/src/libcamera/software_isp/software_isp_instance_gpu.cpp
@@ -183,9 +183,10 @@  int SoftwareIspInstanceGpu::configure(const StreamConfiguration &inputCfg,
 	outputBufferCount_ = outputCfg.bufferCount;
 
 	/* Configure for one pass */
-	PassConfig rawSensorIn = { inputCfg.size, inputConfig_.stride, inputPixelFormat_, window };
+	PassConfig rawSensorIn = { inputCfg.size, inputConfig_.stride, inputPixelFormat_, Rectangle(inputCfg.size) };
 	PassConfig pingPongOut = { inputCfg.size, inputCfg.size.width, inputPixelFormat_, Rectangle(inputCfg.size) };
 	PassConfig pingPongIn = pingPongOut;
+	pingPongIn.window = window;
 	PassConfig rgbaOut = { outputCfg.size, outputConfig_.stride, outputPixelFormat_, Rectangle(nativeOutputSize_) };
 
 	gpuIspShaderPassBlcNormalise_.configure(rawSensorIn, pingPongOut);