@@ -183,9 +183,10 @@ int SoftwareIspInstanceGpu::configure(const StreamConfiguration &inputCfg,
outputBufferCount_ = outputCfg.bufferCount;
/* Configure for one pass */
- PassConfig rawSensorIn = { inputCfg.size, inputConfig_.stride, inputPixelFormat_, window };
+ PassConfig rawSensorIn = { inputCfg.size, inputConfig_.stride, inputPixelFormat_, Rectangle(inputCfg.size) };
PassConfig pingPongOut = { inputCfg.size, inputCfg.size.width, inputPixelFormat_, Rectangle(inputCfg.size) };
PassConfig pingPongIn = pingPongOut;
+ pingPongIn.window = window;
PassConfig rgbaOut = { outputCfg.size, outputConfig_.stride, outputPixelFormat_, Rectangle(nativeOutputSize_) };
gpuIspShaderPassBlcNormalise_.configure(rawSensorIn, pingPongOut);
If we scale in the blc/normalise pass when we write to the output buffer we will be dropping Bayer encoded data. OTOH if we scale at the output of the demosaic phase the data we end up dropping has already been interpolated into RGB. Dropping at the BLC phase means losing the data-source to properly interpolate. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- src/libcamera/software_isp/software_isp_instance_gpu.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)