| Message ID | 20261118095735.170587-22-bryan.odonoghue@linaro.org |
|---|---|
| State | New |
| Headers | show
Return-Path: <libcamera-devel-bounces@lists.libcamera.org> X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1C81FBDE17 for <parsemail@patchwork.libcamera.org>; Wed, 18 Nov 2026 09:58:30 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6075A6A8E7; Wed, 18 Nov 2026 10:58:29 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="lYOmchv9"; dkim-atps=neutral Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A3D56A8E3 for <libcamera-devel@lists.libcamera.org>; Wed, 18 Nov 2026 10:58:11 +0100 (CET) Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-48e20ed3b9dso590461f8f.2 for <libcamera-devel@lists.libcamera.org>; Wed, 18 Nov 2026 01:58:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1794995891; x=1795600691; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0bdIMGSJARuaABcMHiUve+Qx0/XAC6+UYe4ZLALtaWA=; b=lYOmchv95P6waF5TrxhRCq/LZH3u/YDKI+8oMoVBfmHwB4hXzjtBKc8S9r/z6/HvR5 x/EPh1OTK2yeb03gqp4htojgWtLjj3LYzaCJqY4ZNt8buw/AL+CIuEm3z9Nq2QWS9bcB gBXZwSQyn6WgUEbYVophT6iwbyFgG2M6Fb6XWrdNbAt7Z/9ayIN5ATT49OuiqiW6VYRQ oIHElVaO95TfshacknOrP03950W9RnE0UOdqQ+PXoSjvYd0nxCcr60uwiAygT7UBKCCI SeneoHSU94le0wA41vniQQJNTAmzlI9dXO5f5qc7Ihxi/sIs6wtjK7dhhcRxcTahSLq3 AjBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794995891; x=1795600691; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=0bdIMGSJARuaABcMHiUve+Qx0/XAC6+UYe4ZLALtaWA=; b=d7rdBP1qWDTllZnJi5BkckWB2mcPR0q+mKPy3DLIpTNFdA6xXqC09WHYRf+lop8nOI sIxMCK6Ofjl8JEA5BEdYKRoy3CKE4QaiN6e2lTP5y8nDEDKXlM3Um35H8tLEtUYwM+kd pI3LDhzwZ23MbZ3dPiw8SXOwtaVJ1ZRvyK75et0wsx+c6Ll70I9uI//wM4QV3OBxLspk wMMdjapbnche6BHrCt2CZOOShrWnBU8f1PgxYlSC70DA4vUipioUVFIaSBWGM+jctyo3 FbZNSClcE7X5i9SPtGahd2xBkQflRKnTxZmZJDYeA3YEj9d+gg41zEjlb5nmRztAsRMK KdYw== X-Gm-Message-State: APuU4Z8CTWmxJIRoZ+h85LhKktpYdY/Vb+gvs9XVGrUCjkMIZlIazNii rvphcxPAJT0647XSFzBR+nVNzzLUW8RvNd00sdUdKKEw1IUvaIE4StBf9zPP2N0cJBS3YdOp+FE LDTZhxPU= X-Gm-Gg: AZFdTZduvv8LZYW9Al9NRp9xn9VwgouflApUuNTZpJCkwkOyTpJ+0s6Dy7bhybYoFB5 XIhldZTeWdzx+qLTMhBdELmXS1eZ3h74oHx/XciVlmtENLhCi7sjXtzLPKtlWUurM6LuqKfVjov vphJH+mqIh2CCzOuEhol9MN+mAU3sTTFg6smspjAvgl0oixN+VpQZndsCgbhZNseGinqDBtl0Ts /4t/CFzUyu6bn28r93weqrIrlTgxEnaZdulueLEbf06qEj7jPRokRmkLIW9JL4Ey/hKGEXmQCej +g4y9K2CoHmsflLbaqcOT+vlUCA+qL3WwOi/WTTPzYLoQKvGZ53WtiYoDofYlIEMmpgjEOdfCHL l48PvrWGxrUb/mwEzSCynwQ1zaWI+HMr1it/C+7MWrgEGC8U9a7C/0qzdAZz3WEvB/XUAlYTod3 PxGjHwJQZ1MeFtSyqU8J+Ovbe9Q4f3qN8XTM3/uechDtO5U3hsfdJzNNI6yTjhtCXTPodvejher I8Wc2FfqQ1SHc+Yu3KVDf9ng1ImDkromHN4c1uWZkEV86aDSh+0/7J71h50GxP2iUQ5Ypo1RBUW Q62JGgaZ33bptBCAs7CIoBcF06ZZZhndTDmPM87+fUkpzg== X-Received: by 2002:a05:6000:2602:b0:48e:824:f0b9 with SMTP id ffacd0b85a97d-4a63ae5678fmr4103981f8f.45.1794995890596; Wed, 18 Nov 2026 01:58:10 -0800 (PST) Received: from inspiron14p-linux ([109.76.187.112]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4a655f9f4a7sm3940871f8f.34.2026.11.18.01.58.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2026 01:58:09 -0800 (PST) From: Bryan O'Donoghue <bryan.odonoghue@linaro.org> To: libcamera-devel@lists.libcamera.org Cc: rstrode@redhat.com, robert.mader@collabora.com, barnabas.pocze@ideasonboard.com, Bryan O'Donoghue <bryan.odonoghue@linaro.org> Subject: [RFC PATCH v2 21/26] libcamera: shaders: bayer_glr16_to_rgba.frag: Move debayer logic to a routine Date: Wed, 18 Nov 2026 10:57:28 +0100 Message-ID: <20261118095735.170587-22-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261118095735.170587-1-bryan.odonoghue@linaro.org> References: <20261118095735.170587-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: <libcamera-devel.lists.libcamera.org> List-Unsubscribe: <https://lists.libcamera.org/options/libcamera-devel>, <mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe> List-Archive: <https://lists.libcamera.org/pipermail/libcamera-devel/> List-Post: <mailto:libcamera-devel@lists.libcamera.org> List-Help: <mailto:libcamera-devel-request@lists.libcamera.org?subject=help> List-Subscribe: <https://lists.libcamera.org/listinfo/libcamera-devel>, <mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe> Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" <libcamera-devel-bounces@lists.libcamera.org> |
| Series |
|
| Related |
show
|
diff --git a/src/libcamera/shaders/bayer_glr16f_to_rgba.frag b/src/libcamera/shaders/bayer_glr16f_to_rgba.frag index ce334de48..c613e9842 100644 --- a/src/libcamera/shaders/bayer_glr16f_to_rgba.frag +++ b/src/libcamera/shaders/bayer_glr16f_to_rgba.frag @@ -61,12 +61,8 @@ void sample_3x3(inout samples_3x3 samples) samples.row2c = fetch(xCoord[2], yCoord[1]); } -void main(void) { - samples_3x3 samples; - vec3 rgb; - - sample_3x3(samples); - +void bilinear_demosiac(inout vec3 rgb, in samples_3x3 samples) +{ float C = samples.center; /* Which of the four CFA phases are we on (0 = even). Same as McGuire. */ @@ -115,6 +111,15 @@ void main(void) { (even_row ? vec3(patterns.y, C, patterns.x) : vec3(patterns.wz, C)); +} + +void main(void) { + samples_3x3 samples; + vec3 rgb; + + sample_3x3(samples); + + bilinear_demosiac(rgb, samples); /* * CCM is a 3x3 in the format
Tidy up the debayer portion into its own method. We may choose to support different adjacent methods so sectioning off into a standalone method facilitates in addition to isolating and aggregating specific logic to a specific localised place. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- src/libcamera/shaders/bayer_glr16f_to_rgba.frag | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-)