[v2] ipa: {mali-c55,rkisp1}: Expand uncalibrated tuning files
diff mbox series

Message ID 20261012155149.634490-1-barnabas.pocze@ideasonboard.com
State Accepted
Headers show
Series
  • [v2] ipa: {mali-c55,rkisp1}: Expand uncalibrated tuning files
Related show

Commit Message

Barnabás Pőcze Oct. 12, 2026, 3:51 p.m. UTC 
The mali-c55 and rkisp1 uncalibrated tuning files are missing some
algorithms that can be useful without any specific tuning date.

The `Ccm` algorithm provides the manual `ColourCorrectionMatrix` control
even without any specific tuning, which can be useful.

And gamma correction provides the manual `Gamma` control, with a default
of 2.2, without which most image will seem too dark.

Even the default auto white balancing provides better images most of the
time than having no white balancing at all.

And black level correction can of course work using the black level
from the sensor helper.

So these algorithms usually have no reason to be missing. So add them to
the rkisp1 and mali-c55 default tuning files.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
changes in v2:
  * add to mali-c55: Awb, BlackLevelCorrection

v1: https://patchwork.libcamera.org/patch/28392/
---
 src/ipa/mali-c55/data/uncalibrated.yaml | 3 +++
 src/ipa/rkisp1/data/uncalibrated.yaml   | 2 ++
 2 files changed, 5 insertions(+)

--
2.56.0

Comments

Kieran Bingham Oct. 12, 2026, 6:38 p.m. UTC | #1 
Quoting Barnabás Pőcze (2026-10-12 16:51:49)
> The mali-c55 and rkisp1 uncalibrated tuning files are missing some
> algorithms that can be useful without any specific tuning date.
> 
> The `Ccm` algorithm provides the manual `ColourCorrectionMatrix` control
> even without any specific tuning, which can be useful.
> 
> And gamma correction provides the manual `Gamma` control, with a default
> of 2.2, without which most image will seem too dark.
> 
> Even the default auto white balancing provides better images most of the
> time than having no white balancing at all.
> 
> And black level correction can of course work using the black level
> from the sensor helper.
> 
> So these algorithms usually have no reason to be missing. So add them to
> the rkisp1 and mali-c55 default tuning files.
> 
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> ---
> changes in v2:
>   * add to mali-c55: Awb, BlackLevelCorrection

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> v1: https://patchwork.libcamera.org/patch/28392/
> ---
>  src/ipa/mali-c55/data/uncalibrated.yaml | 3 +++
>  src/ipa/rkisp1/data/uncalibrated.yaml   | 2 ++
>  2 files changed, 5 insertions(+)
> 
> diff --git a/src/ipa/mali-c55/data/uncalibrated.yaml b/src/ipa/mali-c55/data/uncalibrated.yaml
> index 6dcc0295ca..ea44c58c9e 100644
> --- a/src/ipa/mali-c55/data/uncalibrated.yaml
> +++ b/src/ipa/mali-c55/data/uncalibrated.yaml
> @@ -4,4 +4,7 @@
>  version: 1
>  algorithms:
>    - Agc:
> +  - Awb:
> +  - BlackLevelCorrection:
> +  - Ccm:
>  ...
> diff --git a/src/ipa/rkisp1/data/uncalibrated.yaml b/src/ipa/rkisp1/data/uncalibrated.yaml
> index 609012967e..3057df83b0 100644
> --- a/src/ipa/rkisp1/data/uncalibrated.yaml
> +++ b/src/ipa/rkisp1/data/uncalibrated.yaml
> @@ -6,4 +6,6 @@ algorithms:
>    - Agc:
>    - Awb:
>    - BlackLevelCorrection:
> +  - Ccm:
> +  - GammaOutCorrection:
>  ...
> --
> 2.56.0
Jacopo Mondi Oct. 13, 2026, 6:51 a.m. UTC | #2 
Hi Barnabás

On Mon, Oct 12, 2026 at 05:51:49PM +0200, Barnabás Pőcze wrote:
> The mali-c55 and rkisp1 uncalibrated tuning files are missing some
> algorithms that can be useful without any specific tuning date.
>
> The `Ccm` algorithm provides the manual `ColourCorrectionMatrix` control
> even without any specific tuning, which can be useful.
>
> And gamma correction provides the manual `Gamma` control, with a default
> of 2.2, without which most image will seem too dark.
>
> Even the default auto white balancing provides better images most of the
> time than having no white balancing at all.
>
> And black level correction can of course work using the black level
> from the sensor helper.
>
> So these algorithms usually have no reason to be missing. So add them to
> the rkisp1 and mali-c55 default tuning files.
>
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> ---
> changes in v2:
>   * add to mali-c55: Awb, BlackLevelCorrection
>
> v1: https://patchwork.libcamera.org/patch/28392/
> ---
>  src/ipa/mali-c55/data/uncalibrated.yaml | 3 +++
>  src/ipa/rkisp1/data/uncalibrated.yaml   | 2 ++
>  2 files changed, 5 insertions(+)
>
> diff --git a/src/ipa/mali-c55/data/uncalibrated.yaml b/src/ipa/mali-c55/data/uncalibrated.yaml
> index 6dcc0295ca..ea44c58c9e 100644
> --- a/src/ipa/mali-c55/data/uncalibrated.yaml
> +++ b/src/ipa/mali-c55/data/uncalibrated.yaml
> @@ -4,4 +4,7 @@
>  version: 1
>  algorithms:
>    - Agc:
> +  - Awb:
> +  - BlackLevelCorrection:
> +  - Ccm:

Why no Gamma for Mali ?

>  ...
> diff --git a/src/ipa/rkisp1/data/uncalibrated.yaml b/src/ipa/rkisp1/data/uncalibrated.yaml
> index 609012967e..3057df83b0 100644
> --- a/src/ipa/rkisp1/data/uncalibrated.yaml
> +++ b/src/ipa/rkisp1/data/uncalibrated.yaml
> @@ -6,4 +6,6 @@ algorithms:
>    - Agc:
>    - Awb:
>    - BlackLevelCorrection:
> +  - Ccm:
> +  - GammaOutCorrection:
>  ...
> --
> 2.56.0
Barnabás Pőcze Oct. 13, 2026, 7:11 a.m. UTC | #3 
2026. 10. 13. 8:51 keltezéssel, Jacopo Mondi írta:
> Hi Barnabás
> 
> On Mon, Oct 12, 2026 at 05:51:49PM +0200, Barnabás Pőcze wrote:
>> The mali-c55 and rkisp1 uncalibrated tuning files are missing some
>> algorithms that can be useful without any specific tuning date.
>>
>> The `Ccm` algorithm provides the manual `ColourCorrectionMatrix` control
>> even without any specific tuning, which can be useful.
>>
>> And gamma correction provides the manual `Gamma` control, with a default
>> of 2.2, without which most image will seem too dark.
>>
>> Even the default auto white balancing provides better images most of the
>> time than having no white balancing at all.
>>
>> And black level correction can of course work using the black level
>> from the sensor helper.
>>
>> So these algorithms usually have no reason to be missing. So add them to
>> the rkisp1 and mali-c55 default tuning files.
>>
>> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
>> ---
>> changes in v2:
>>    * add to mali-c55: Awb, BlackLevelCorrection
>>
>> v1: https://patchwork.libcamera.org/patch/28392/
>> ---
>>   src/ipa/mali-c55/data/uncalibrated.yaml | 3 +++
>>   src/ipa/rkisp1/data/uncalibrated.yaml   | 2 ++
>>   2 files changed, 5 insertions(+)
>>
>> diff --git a/src/ipa/mali-c55/data/uncalibrated.yaml b/src/ipa/mali-c55/data/uncalibrated.yaml
>> index 6dcc0295ca..ea44c58c9e 100644
>> --- a/src/ipa/mali-c55/data/uncalibrated.yaml
>> +++ b/src/ipa/mali-c55/data/uncalibrated.yaml
>> @@ -4,4 +4,7 @@
>>   version: 1
>>   algorithms:
>>     - Agc:
>> +  - Awb:
>> +  - BlackLevelCorrection:
>> +  - Ccm:
> 
> Why no Gamma for Mali ?

It's not yet upstream sadly. I can take a look at doing that later, though?


> 
>>   ...
>> diff --git a/src/ipa/rkisp1/data/uncalibrated.yaml b/src/ipa/rkisp1/data/uncalibrated.yaml
>> index 609012967e..3057df83b0 100644
>> --- a/src/ipa/rkisp1/data/uncalibrated.yaml
>> +++ b/src/ipa/rkisp1/data/uncalibrated.yaml
>> @@ -6,4 +6,6 @@ algorithms:
>>     - Agc:
>>     - Awb:
>>     - BlackLevelCorrection:
>> +  - Ccm:
>> +  - GammaOutCorrection:
>>   ...
>> --
>> 2.56.0
Jacopo Mondi Oct. 13, 2026, 7:46 a.m. UTC | #4 
On Tue, Oct 13, 2026 at 09:11:22AM +0200, Barnabás Pőcze wrote:
> 2026. 10. 13. 8:51 keltezéssel, Jacopo Mondi írta:
> > Hi Barnabás
> >
> > On Mon, Oct 12, 2026 at 05:51:49PM +0200, Barnabás Pőcze wrote:
> > > The mali-c55 and rkisp1 uncalibrated tuning files are missing some
> > > algorithms that can be useful without any specific tuning date.
> > >
> > > The `Ccm` algorithm provides the manual `ColourCorrectionMatrix` control
> > > even without any specific tuning, which can be useful.
> > >
> > > And gamma correction provides the manual `Gamma` control, with a default
> > > of 2.2, without which most image will seem too dark.
> > >
> > > Even the default auto white balancing provides better images most of the
> > > time than having no white balancing at all.
> > >
> > > And black level correction can of course work using the black level
> > > from the sensor helper.
> > >
> > > So these algorithms usually have no reason to be missing. So add them to
> > > the rkisp1 and mali-c55 default tuning files.
> > >
> > > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> > > ---
> > > changes in v2:
> > >    * add to mali-c55: Awb, BlackLevelCorrection
> > >
> > > v1: https://patchwork.libcamera.org/patch/28392/
> > > ---
> > >   src/ipa/mali-c55/data/uncalibrated.yaml | 3 +++
> > >   src/ipa/rkisp1/data/uncalibrated.yaml   | 2 ++
> > >   2 files changed, 5 insertions(+)
> > >
> > > diff --git a/src/ipa/mali-c55/data/uncalibrated.yaml b/src/ipa/mali-c55/data/uncalibrated.yaml
> > > index 6dcc0295ca..ea44c58c9e 100644
> > > --- a/src/ipa/mali-c55/data/uncalibrated.yaml
> > > +++ b/src/ipa/mali-c55/data/uncalibrated.yaml
> > > @@ -4,4 +4,7 @@
> > >   version: 1
> > >   algorithms:
> > >     - Agc:
> > > +  - Awb:
> > > +  - BlackLevelCorrection:
> > > +  - Ccm:
> >
> > Why no Gamma for Mali ?
>
> It's not yet upstream sadly. I can take a look at doing that later, though?

Ah indeed, I had

$ ls src/ipa/mali-c55/algorithms/gamma.*
src/ipa/mali-c55/algorithms/gamma.cpp  src/ipa/mali-c55/algorithms/gamma.h

in my tree, but not on mainline :(

>
>
> >
> > >   ...
> > > diff --git a/src/ipa/rkisp1/data/uncalibrated.yaml b/src/ipa/rkisp1/data/uncalibrated.yaml
> > > index 609012967e..3057df83b0 100644
> > > --- a/src/ipa/rkisp1/data/uncalibrated.yaml
> > > +++ b/src/ipa/rkisp1/data/uncalibrated.yaml
> > > @@ -6,4 +6,6 @@ algorithms:
> > >     - Agc:
> > >     - Awb:
> > >     - BlackLevelCorrection:
> > > +  - Ccm:
> > > +  - GammaOutCorrection:
> > >   ...
> > > --
> > > 2.56.0
>
Jacopo Mondi Oct. 20, 2026, 12:29 p.m. UTC | #5 
Hi Barnabás

On Tue, Oct 13, 2026 at 09:46:34AM +0200, Jacopo Mondi wrote:
> On Tue, Oct 13, 2026 at 09:11:22AM +0200, Barnabás Pőcze wrote:
> > 2026. 10. 13. 8:51 keltezéssel, Jacopo Mondi írta:
> > > Hi Barnabás
> > >
> > > On Mon, Oct 12, 2026 at 05:51:49PM +0200, Barnabás Pőcze wrote:
> > > > The mali-c55 and rkisp1 uncalibrated tuning files are missing some
> > > > algorithms that can be useful without any specific tuning date.
> > > >
> > > > The `Ccm` algorithm provides the manual `ColourCorrectionMatrix` control
> > > > even without any specific tuning, which can be useful.
> > > >
> > > > And gamma correction provides the manual `Gamma` control, with a default
> > > > of 2.2, without which most image will seem too dark.
> > > >
> > > > Even the default auto white balancing provides better images most of the
> > > > time than having no white balancing at all.
> > > >
> > > > And black level correction can of course work using the black level
> > > > from the sensor helper.
> > > >
> > > > So these algorithms usually have no reason to be missing. So add them to
> > > > the rkisp1 and mali-c55 default tuning files.
> > > >
> > > > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>

Seems like I forgot a tag here
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Can this be merged now ?

> > > > ---
> > > > changes in v2:
> > > >    * add to mali-c55: Awb, BlackLevelCorrection
> > > >
> > > > v1: https://patchwork.libcamera.org/patch/28392/
> > > > ---
> > > >   src/ipa/mali-c55/data/uncalibrated.yaml | 3 +++
> > > >   src/ipa/rkisp1/data/uncalibrated.yaml   | 2 ++
> > > >   2 files changed, 5 insertions(+)
> > > >
> > > > diff --git a/src/ipa/mali-c55/data/uncalibrated.yaml b/src/ipa/mali-c55/data/uncalibrated.yaml
> > > > index 6dcc0295ca..ea44c58c9e 100644
> > > > --- a/src/ipa/mali-c55/data/uncalibrated.yaml
> > > > +++ b/src/ipa/mali-c55/data/uncalibrated.yaml
> > > > @@ -4,4 +4,7 @@
> > > >   version: 1
> > > >   algorithms:
> > > >     - Agc:
> > > > +  - Awb:
> > > > +  - BlackLevelCorrection:
> > > > +  - Ccm:
> > >
> > > Why no Gamma for Mali ?
> >
> > It's not yet upstream sadly. I can take a look at doing that later, though?
>
> Ah indeed, I had
>
> $ ls src/ipa/mali-c55/algorithms/gamma.*
> src/ipa/mali-c55/algorithms/gamma.cpp  src/ipa/mali-c55/algorithms/gamma.h
>
> in my tree, but not on mainline :(
>
> >
> >
> > >
> > > >   ...
> > > > diff --git a/src/ipa/rkisp1/data/uncalibrated.yaml b/src/ipa/rkisp1/data/uncalibrated.yaml
> > > > index 609012967e..3057df83b0 100644
> > > > --- a/src/ipa/rkisp1/data/uncalibrated.yaml
> > > > +++ b/src/ipa/rkisp1/data/uncalibrated.yaml
> > > > @@ -6,4 +6,6 @@ algorithms:
> > > >     - Agc:
> > > >     - Awb:
> > > >     - BlackLevelCorrection:
> > > > +  - Ccm:
> > > > +  - GammaOutCorrection:
> > > >   ...
> > > > --
> > > > 2.56.0
> >
Barnabás Pőcze Oct. 20, 2026, 12:45 p.m. UTC | #6 
2026. 10. 20. 14:29 keltezéssel, Jacopo Mondi írta:
> Hi Barnabás
> 
> On Tue, Oct 13, 2026 at 09:46:34AM +0200, Jacopo Mondi wrote:
>> On Tue, Oct 13, 2026 at 09:11:22AM +0200, Barnabás Pőcze wrote:
>>> 2026. 10. 13. 8:51 keltezéssel, Jacopo Mondi írta:
>>>> Hi Barnabás
>>>>
>>>> On Mon, Oct 12, 2026 at 05:51:49PM +0200, Barnabás Pőcze wrote:
>>>>> The mali-c55 and rkisp1 uncalibrated tuning files are missing some
>>>>> algorithms that can be useful without any specific tuning date.
>>>>>
>>>>> The `Ccm` algorithm provides the manual `ColourCorrectionMatrix` control
>>>>> even without any specific tuning, which can be useful.
>>>>>
>>>>> And gamma correction provides the manual `Gamma` control, with a default
>>>>> of 2.2, without which most image will seem too dark.
>>>>>
>>>>> Even the default auto white balancing provides better images most of the
>>>>> time than having no white balancing at all.
>>>>>
>>>>> And black level correction can of course work using the black level
>>>>> from the sensor helper.
>>>>>
>>>>> So these algorithms usually have no reason to be missing. So add them to
>>>>> the rkisp1 and mali-c55 default tuning files.
>>>>>
>>>>> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> 
> Seems like I forgot a tag here
> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> 
> Can this be merged now ?

Yes, I'm doing that right now.


> 
>>>>> ---
>>>>> changes in v2:
>>>>>     * add to mali-c55: Awb, BlackLevelCorrection
>>>>>
>>>>> v1: https://patchwork.libcamera.org/patch/28392/
>>>>> ---
>>>>>    src/ipa/mali-c55/data/uncalibrated.yaml | 3 +++
>>>>>    src/ipa/rkisp1/data/uncalibrated.yaml   | 2 ++
>>>>>    2 files changed, 5 insertions(+)
>>>>>
>>>>> diff --git a/src/ipa/mali-c55/data/uncalibrated.yaml b/src/ipa/mali-c55/data/uncalibrated.yaml
>>>>> index 6dcc0295ca..ea44c58c9e 100644
>>>>> --- a/src/ipa/mali-c55/data/uncalibrated.yaml
>>>>> +++ b/src/ipa/mali-c55/data/uncalibrated.yaml
>>>>> @@ -4,4 +4,7 @@
>>>>>    version: 1
>>>>>    algorithms:
>>>>>      - Agc:
>>>>> +  - Awb:
>>>>> +  - BlackLevelCorrection:
>>>>> +  - Ccm:
>>>>
>>>> Why no Gamma for Mali ?
>>>
>>> It's not yet upstream sadly. I can take a look at doing that later, though?
>>
>> Ah indeed, I had
>>
>> $ ls src/ipa/mali-c55/algorithms/gamma.*
>> src/ipa/mali-c55/algorithms/gamma.cpp  src/ipa/mali-c55/algorithms/gamma.h
>>
>> in my tree, but not on mainline :(
>>
>>>
>>>
>>>>
>>>>>    ...
>>>>> diff --git a/src/ipa/rkisp1/data/uncalibrated.yaml b/src/ipa/rkisp1/data/uncalibrated.yaml
>>>>> index 609012967e..3057df83b0 100644
>>>>> --- a/src/ipa/rkisp1/data/uncalibrated.yaml
>>>>> +++ b/src/ipa/rkisp1/data/uncalibrated.yaml
>>>>> @@ -6,4 +6,6 @@ algorithms:
>>>>>      - Agc:
>>>>>      - Awb:
>>>>>      - BlackLevelCorrection:
>>>>> +  - Ccm:
>>>>> +  - GammaOutCorrection:
>>>>>    ...
>>>>> --
>>>>> 2.56.0
>>>

Patch
diff mbox series 

diff --git a/src/ipa/mali-c55/data/uncalibrated.yaml b/src/ipa/mali-c55/data/uncalibrated.yaml
index 6dcc0295ca..ea44c58c9e 100644
--- a/src/ipa/mali-c55/data/uncalibrated.yaml
+++ b/src/ipa/mali-c55/data/uncalibrated.yaml
@@ -4,4 +4,7 @@ 
 version: 1
 algorithms:
   - Agc:
+  - Awb:
+  - BlackLevelCorrection:
+  - Ccm:
 ...
diff --git a/src/ipa/rkisp1/data/uncalibrated.yaml b/src/ipa/rkisp1/data/uncalibrated.yaml
index 609012967e..3057df83b0 100644
--- a/src/ipa/rkisp1/data/uncalibrated.yaml
+++ b/src/ipa/rkisp1/data/uncalibrated.yaml
@@ -6,4 +6,6 @@  algorithms:
   - Agc:
   - Awb:
   - BlackLevelCorrection:
+  - Ccm:
+  - GammaOutCorrection:
 ...