[v2] ipa: {mali-c55,rkisp1}: Expand uncalibrated tuning files

28439 diff mbox series

The mali-c55 and rkisp1 uncalibrated tuning files are missing some
algorithms that can be useful without any specific tuning date.

The `Ccm` algorithm provides the manual `ColourCorrectionMatrix` control
even without any specific tuning, which can be useful.

And gamma correction provides the manual `Gamma` control, with a default
of 2.2, without which most image will seem too dark.

Even the default auto white balancing provides better images most of the
time than having no white balancing at all.

And black level correction can of course work using the black level
from the sensor helper.

So these algorithms usually have no reason to be missing. So add them to
the rkisp1 and mali-c55 default tuning files.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
changes in v2:
  * add to mali-c55: Awb, BlackLevelCorrection

v1: https://patchwork.libcamera.org/patch/28392/
---
 src/ipa/mali-c55/data/uncalibrated.yaml | 3 +++
 src/ipa/rkisp1/data/uncalibrated.yaml   | 2 ++
 2 files changed, 5 insertions(+)

--
2.56.0

Quoting Barnabás Pőcze (2026-10-12 16:51:49)
> The mali-c55 and rkisp1 uncalibrated tuning files are missing some
> algorithms that can be useful without any specific tuning date.
> 
> The `Ccm` algorithm provides the manual `ColourCorrectionMatrix` control
> even without any specific tuning, which can be useful.
> 
> And gamma correction provides the manual `Gamma` control, with a default
> of 2.2, without which most image will seem too dark.
> 
> Even the default auto white balancing provides better images most of the
> time than having no white balancing at all.
> 
> And black level correction can of course work using the black level
> from the sensor helper.
> 
> So these algorithms usually have no reason to be missing. So add them to
> the rkisp1 and mali-c55 default tuning files.
> 
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> ---
> changes in v2:
>   * add to mali-c55: Awb, BlackLevelCorrection

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> v1: https://patchwork.libcamera.org/patch/28392/
> ---
>  src/ipa/mali-c55/data/uncalibrated.yaml | 3 +++
>  src/ipa/rkisp1/data/uncalibrated.yaml   | 2 ++
>  2 files changed, 5 insertions(+)
> 
> diff --git a/src/ipa/mali-c55/data/uncalibrated.yaml b/src/ipa/mali-c55/data/uncalibrated.yaml
> index 6dcc0295ca..ea44c58c9e 100644
> --- a/src/ipa/mali-c55/data/uncalibrated.yaml
> +++ b/src/ipa/mali-c55/data/uncalibrated.yaml
> @@ -4,4 +4,7 @@
>  version: 1
>  algorithms:
>    - Agc:
> +  - Awb:
> +  - BlackLevelCorrection:
> +  - Ccm:
>  ...
> diff --git a/src/ipa/rkisp1/data/uncalibrated.yaml b/src/ipa/rkisp1/data/uncalibrated.yaml
> index 609012967e..3057df83b0 100644
> --- a/src/ipa/rkisp1/data/uncalibrated.yaml
> +++ b/src/ipa/rkisp1/data/uncalibrated.yaml
> @@ -6,4 +6,6 @@ algorithms:
>    - Agc:
>    - Awb:
>    - BlackLevelCorrection:
> +  - Ccm:
> +  - GammaOutCorrection:
>  ...
> --
> 2.56.0