From patchwork Mon Oct 12 15:51:49 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 28439 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id ADA00BDCB6 for ; Mon, 12 Oct 2026 15:51:55 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 43BB968A6B; Mon, 12 Oct 2026 17:51:54 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="YkbGzMP0"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id ADA8768A2D for ; Mon, 12 Oct 2026 17:51:52 +0200 (CEST) Received: from pb-laptop.local (185.221.143.22.nat.pool.zt.hu [185.221.143.22]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BCFDA2F8 for ; Mon, 12 Oct 2026 17:49:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1791820191; bh=GczsTMMUegqHNPrsSLg+mJfMUATNGYnfeAXYMmC1e00=; h=From:To:Subject:Date:From; b=YkbGzMP0pqhxp0kxsTUE80qKIXQpwQQyV1pFhHdjnvX/NHD6DkoljJMOxuRuPHmi5 FgIRElpWOOu6rMHeQCh/1rITffFCHT8+a+4YvhlIun3crshwrbSHW6dId8pmbbayTt k8ed4DJNoe3uteBQR78X6ydw5Lkklrv46+vFA9wQ= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [PATCH v2] ipa: {mali-c55, rkisp1}: Expand uncalibrated tuning files Date: Mon, 12 Oct 2026 17:51:49 +0200 Message-ID: <20261012155149.634490-1-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.56.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The mali-c55 and rkisp1 uncalibrated tuning files are missing some algorithms that can be useful without any specific tuning date. The `Ccm` algorithm provides the manual `ColourCorrectionMatrix` control even without any specific tuning, which can be useful. And gamma correction provides the manual `Gamma` control, with a default of 2.2, without which most image will seem too dark. Even the default auto white balancing provides better images most of the time than having no white balancing at all. And black level correction can of course work using the black level from the sensor helper. So these algorithms usually have no reason to be missing. So add them to the rkisp1 and mali-c55 default tuning files. Signed-off-by: Barnabás Pőcze Reviewed-by: Kieran Bingham --- changes in v2: * add to mali-c55: Awb, BlackLevelCorrection v1: https://patchwork.libcamera.org/patch/28392/ --- src/ipa/mali-c55/data/uncalibrated.yaml | 3 +++ src/ipa/rkisp1/data/uncalibrated.yaml | 2 ++ 2 files changed, 5 insertions(+) -- 2.56.0 diff --git a/src/ipa/mali-c55/data/uncalibrated.yaml b/src/ipa/mali-c55/data/uncalibrated.yaml index 6dcc0295ca..ea44c58c9e 100644 --- a/src/ipa/mali-c55/data/uncalibrated.yaml +++ b/src/ipa/mali-c55/data/uncalibrated.yaml @@ -4,4 +4,7 @@ version: 1 algorithms: - Agc: + - Awb: + - BlackLevelCorrection: + - Ccm: ... diff --git a/src/ipa/rkisp1/data/uncalibrated.yaml b/src/ipa/rkisp1/data/uncalibrated.yaml index 609012967e..3057df83b0 100644 --- a/src/ipa/rkisp1/data/uncalibrated.yaml +++ b/src/ipa/rkisp1/data/uncalibrated.yaml @@ -6,4 +6,6 @@ algorithms: - Agc: - Awb: - BlackLevelCorrection: + - Ccm: + - GammaOutCorrection: ...