[v7,02/47] ipa: softisp: Remove control presence sanity check
diff mbox series

Message ID 20260821130218.2706196-3-barnabas.pocze@ideasonboard.com
State New
Headers show
Series
  • ipa: libipa: agc rework
Related show

Commit Message

Barnabás Pőcze Aug. 21, 2026, 1:01 p.m. UTC 
The check is useless because `DelayedControls::get()` always populates
the result even if the value is "none", so the presence check will
always succeed. And furthermore the check also has the issue of being
later than the actual access.

Link: https://gitlab.freedesktop.org/camera/libcamera/-/work_items/241
Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Milan Zamazal <mzamazal@redhat.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
 src/ipa/softisp/softisp.cpp | 7 -------
 1 file changed, 7 deletions(-)

Patch
diff mbox series 

diff --git a/src/ipa/softisp/softisp.cpp b/src/ipa/softisp/softisp.cpp
index aec04c528c..f1a04bf53e 100644
--- a/src/ipa/softisp/softisp.cpp
+++ b/src/ipa/softisp/softisp.cpp
@@ -311,13 +311,6 @@  void IPASoftIsp::processStats(const uint32_t frame,
 		algo->process(context_, frame, frameContext, stats_, metadata);
 	metadataReady.emit(frame, metadata);
 
-	/* Sanity check */
-	if (!sensorControls.contains(V4L2_CID_EXPOSURE) ||
-	    !sensorControls.contains(V4L2_CID_ANALOGUE_GAIN)) {
-		LOG(IPASoftIsp, Error) << "Control(s) missing";
-		return;
-	}
-
 	ControlList ctrls(sensorInfoMap_);
 
 	auto &againNew = frameContext.sensor.gain;