[v7,00/47] ipa: libipa: agc rework

27963 mbox series

This adds an `AgcAlgorithm` that is essentially a copy of the rkisp1 agc algorithm,
only that it can either use AgcMeanLuminance or the agc algorithm from the simple ipa
module (which is now moved into libipa).

Similarly to the previous versions, the following ipa modules are converted:
  * ipu3
  * mali-c55
  * rkisp1
  * softisp

This applies on top of the current master branch.

changes in v7:
  * add more documentation
  * apply more review comments

changes in v6:
  * apply more review comments
  * adjust to simple->softisp rename

changes in v5:
  * drop more technically unnecessary changes
  * merge the "move" and "rkisp1 porting" changes

changes in v4:
  * drop vblank enablement because it seemingly causes
    oscillation on ipu3

v6: https://patchwork.libcamera.org/cover/27905/
v5: https://patchwork.libcamera.org/cover/27778/
v4: https://patchwork.libcamera.org/cover/27672/
v3: https://patchwork.libcamera.org/cover/27549/
v2: https://patchwork.libcamera.org/cover/27449/
v1: https://patchwork.libcamera.org/cover/27179/

Barnabás Pőcze (46):
  libcamera: software_isp: init(): Fix documentation typo
  ipa: softisp: Remove control presence sanity check
  ipa: softisp: agc: Do not overwrite sensor exposure/gain
  ipa: rkisp1: Remove `IPASessionConfiguration::sensor.defVBlank`
  ipa: rkisp1: Move sensor control info map to context
  ipa: rkisp1: Update sensor info when configuring
  ipa: rkisp1: updateControls(): Use sensor info from context
  ipa: rkisp1: Move AGC related controls into AGC algorithm
  ipa: libipa: agc_mean_luminance: Remove the need for inheritance
  ipa: mali-c55: Remove `DigitalGain` support
  ipa: libipa: agc_mean_luminance: Avoid some duplicate lookups
  ipa: libipa: agc_mean_luminance: Remove unnecessary `std::shared_ptr`
  ipa: libipa: agc_mean_luminance: calculateNewEv(): Fix typo
  ipa: libipa: agc_mean_luminance: calculateNewEv(): Collect params
  ipa: libipa: agc_mean_luminance: constraintClampGain(): Mark `const`
  ipa: libipa: agc_mean_luminance: calculateNewEv(): Collect results
  ipa: libipa: agc_mean_luminance: calculateNewEv(): Return y target
  ipa: libipa: agc_mean_luminance: Remove persistent params
  ipa: libipa: agc_mean_luminance: Reset `filteredExposure_` when
    configuring
  ipa: Simplify sensor exposure/gain setting/getting
  ipa: libipa: Add `AgcAlgorithm`
  ipa: libipa: agc: Adjust controls based on "auto" availablity
  ipa: libipa: agc: Omit `setLimits()` in `configure()`
  ipa: libipa: agc: Use default exposure
  ipa: libipa: agc: Use full range as default `FrameDurationLimits`
  ipa: libipa: agc: Adjust debug messages slightly
  ipa: libipa: agc: Store digital gain
  ipa: libipa: agc: Use minimum line length
  ipa: libipa: agc: Fix multiplication type
  ipa: mali-c55: agc: Port to `AgcAlgorithm`
  ipa: ipu3: agc: Port to `AgcAlgorithm`
  ipa: libipa: agc_mean_luminance: Remove control handling
  ipa: libipa: histogram: total(): Use `back()`
  ipa: libipa: histogram: Add `operator[]` to query bin
  ipa: softisp: Store exposure as `uint32_t`
  ipa: softisp: agc: Separate MSV calculation
  ipa: softisp: agc: Simplify min gain step handling
  ipa: softisp: agc: Use `Histogram`
  ipa: softisp: agc: Adjust histogram for black level
  ipa: softisp: agc: Move to libipa
  ipa: libipa: agc_msv: Ensure limits are always respected
  ipa: libipa: agc_msv: Handle min gain > 1.0 case
  ipa: softisp: Move sensor helper and controls to context
  ipa: softisp: Update controls after configuration
  ipa: libipa: agc: Work without `CameraSensorHelper`
  ipa: softisp: agc: Port to `AgcAlgorithm`

Jacopo Mondi (1):
  ipa: libipa: agc_mean_luminance: Fold resetFrameCount() in configure()

 .../internal/software_isp/software_isp.h      |   3 +-
 include/libcamera/ipa/softisp.mojom           |   2 +-
 src/ipa/ipu3/algorithms/agc.cpp               | 201 ++---
 src/ipa/ipu3/algorithms/agc.h                 |  21 +-
 src/ipa/ipu3/ipa_context.cpp                  |  49 +-
 src/ipa/ipu3/ipa_context.h                    |  30 +-
 src/ipa/ipu3/ipu3.cpp                         | 139 +--
 src/ipa/libipa/agc.cpp                        | 823 ++++++++++++++++++
 src/ipa/libipa/agc.h                          | 170 ++++
 src/ipa/libipa/agc_mean_luminance.cpp         | 254 +++---
 src/ipa/libipa/agc_mean_luminance.h           |  61 +-
 src/ipa/libipa/agc_msv.cpp                    | 238 +++++
 src/ipa/libipa/agc_msv.h                      |  52 ++
 src/ipa/libipa/exposure_mode_helper.cpp       |  19 +-
 src/ipa/libipa/exposure_mode_helper.h         |  11 +-
 src/ipa/libipa/histogram.cpp                  |   6 +
 src/ipa/libipa/histogram.h                    |   7 +-
 src/ipa/libipa/meson.build                    |   4 +
 src/ipa/mali-c55/algorithms/agc.cpp           | 207 +----
 src/ipa/mali-c55/algorithms/agc.h             |   9 +-
 src/ipa/mali-c55/ipa_context.h                |  37 +-
 src/ipa/mali-c55/mali-c55.cpp                 | 165 +---
 src/ipa/rkisp1/algorithms/agc.cpp             | 457 +++-------
 src/ipa/rkisp1/algorithms/agc.h               |  15 +-
 src/ipa/rkisp1/algorithms/lux.cpp             |   2 +-
 src/ipa/rkisp1/ipa_context.cpp                | 104 +--
 src/ipa/rkisp1/ipa_context.h                  |  50 +-
 src/ipa/rkisp1/rkisp1.cpp                     | 128 +--
 src/ipa/softisp/algorithms/agc.cpp            | 221 ++---
 src/ipa/softisp/algorithms/agc.h              |  15 +-
 src/ipa/softisp/algorithms/blc.cpp            |  12 +
 src/ipa/softisp/ipa_context.h                 |  23 +-
 src/ipa/softisp/softisp.cpp                   | 102 +--
 src/libcamera/pipeline/simple/simple.cpp      |   2 +-
 src/libcamera/software_isp/software_isp.cpp   |  12 +-
 35 files changed, 1958 insertions(+), 1693 deletions(-)
 create mode 100644 src/ipa/libipa/agc.cpp
 create mode 100644 src/ipa/libipa/agc.h
 create mode 100644 src/ipa/libipa/agc_msv.cpp
 create mode 100644 src/ipa/libipa/agc_msv.h

--
2.55.0