[v4,24/49] ipa: libipa: agc: Use full range as default `FrameDurationLimits`
diff mbox series

Message ID 20260810103846.1075936-25-barnabas.pocze@ideasonboard.com
State Superseded
Headers show
Series
  • ipa: libipa: agc rework
Related show

Commit Message

Barnabás Pőcze Aug. 10, 2026, 10:38 a.m. UTC
Currently the default value for `FrameDurationLimits` is meaningless
because the full range is used by default. So advertise the full range.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
 src/ipa/libipa/agc.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefan Klug Aug. 11, 2026, 4:12 p.m. UTC | #1
Quoting Barnabás Pőcze (2026-08-10 12:38:20)
> Currently the default value for `FrameDurationLimits` is meaningless
> because the full range is used by default. So advertise the full range.
> 
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>

Best regards,
Stefan

> ---
>  src/ipa/libipa/agc.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp
> index fbda9038e2..6f10f8982f 100644
> --- a/src/ipa/libipa/agc.cpp
> +++ b/src/ipa/libipa/agc.cpp
> @@ -372,7 +372,7 @@ int AgcAlgorithm::configure(agc::Session &session, agc::ActiveState &state,
>         config.ctrlMap[&controls::FrameDurationLimits] = ControlInfo{
>                 frameDurations[0],
>                 frameDurations[1],
> -               Span<const int64_t, 2>{ { frameDurations[2], frameDurations[2] } },
> +               Span<const int64_t, 2>{ { frameDurations[0], frameDurations[1] } },
>         };
>  
>         if (session.autoAllowed) {
> -- 
> 2.55.0
>

Patch
diff mbox series

diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp
index fbda9038e2..6f10f8982f 100644
--- a/src/ipa/libipa/agc.cpp
+++ b/src/ipa/libipa/agc.cpp
@@ -372,7 +372,7 @@  int AgcAlgorithm::configure(agc::Session &session, agc::ActiveState &state,
 	config.ctrlMap[&controls::FrameDurationLimits] = ControlInfo{
 		frameDurations[0],
 		frameDurations[1],
-		Span<const int64_t, 2>{ { frameDurations[2], frameDurations[2] } },
+		Span<const int64_t, 2>{ { frameDurations[0], frameDurations[1] } },
 	};
 
 	if (session.autoAllowed) {