[v4,22/49] ipa: libipa: agc: Omit `setLimits()` in `configure()`
diff mbox series

Message ID 20260810103846.1075936-23-barnabas.pocze@ideasonboard.com
State Superseded
Headers show
Series
  • ipa: libipa: agc rework
Related show

Commit Message

Barnabás Pőcze Aug. 10, 2026, 10:38 a.m. UTC 
`AgcMeanLuminance::setLimits()` is only required to be called before
`calculateNewEv()`, so the call in `configure()` has no real effect
because no calculation is carried out. So remove it.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
 src/ipa/libipa/agc.cpp | 3 ---
 1 file changed, 3 deletions(-)

Comments

Stefan Klug Aug. 11, 2026, 4:07 p.m. UTC | #1 
Quoting Barnabás Pőcze (2026-08-10 12:38:18)
> `AgcMeanLuminance::setLimits()` is only required to be called before
> `calculateNewEv()`, so the call in `configure()` has no real effect
> because no calculation is carried out. So remove it.
> 
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com> 

Best regards,
Stefan

> ---
>  src/ipa/libipa/agc.cpp | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp
> index 4825cdb48e..05d6442000 100644
> --- a/src/ipa/libipa/agc.cpp
> +++ b/src/ipa/libipa/agc.cpp
> @@ -313,9 +313,6 @@ int AgcAlgorithm::configure(agc::Session &session, agc::ActiveState &state,
>         session.maxFrameDuration = std::chrono::microseconds(frameDurations[1]);
>  
>         impl_.configure(session.lineDuration, config.sensor);
> -       impl_.setLimits(session.minExposureTime, session.maxExposureTime,
> -                       session.minAnalogueGain, session.maxAnalogueGain,
> -                       {});
>         impl_.resetFrameCount();
>  
>         /* Configure the default exposure and gain. */
> -- 
> 2.55.0
>

Patch
diff mbox series 

diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp
index 4825cdb48e..05d6442000 100644
--- a/src/ipa/libipa/agc.cpp
+++ b/src/ipa/libipa/agc.cpp
@@ -313,9 +313,6 @@  int AgcAlgorithm::configure(agc::Session &session, agc::ActiveState &state,
 	session.maxFrameDuration = std::chrono::microseconds(frameDurations[1]);
 
 	impl_.configure(session.lineDuration, config.sensor);
-	impl_.setLimits(session.minExposureTime, session.maxExposureTime,
-			session.minAnalogueGain, session.maxAnalogueGain,
-			{});
 	impl_.resetFrameCount();
 
 	/* Configure the default exposure and gain. */