| Message ID | 20200131160846.13084-1-kieran.bingham@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | b448bfb426067a05d92a51f3ff123898a91ea643 |
| Headers | show |
| Series |
|
| Related | show |
diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h index a6c1e1fbae38..97157dd75c8a 100644 --- a/src/libcamera/include/pipeline_handler.h +++ b/src/libcamera/include/pipeline_handler.h @@ -12,7 +12,7 @@ #include <memory> #include <set> #include <string> -#include <sys/sysmacros.h> +#include <sys/types.h> #include <vector> #include <ipa/ipa_interface.h>
Compiling with gcc 9.2.0-r5 identifies the following compile time failure: FAILED: src/libcamera/4ab8042@@camera@sha/camera.cpp.o c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++14 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/camera.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/camera.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/camera.cpp.o' -c ../src/libcamera/camera.cpp In file included from ../src/libcamera/camera.cpp:17: ../src/libcamera/include/pipeline_handler.h:91:42: error: 'dev_t' has not been declared 91 | std::unique_ptr<CameraData> data, dev_t devnum = 0); | ^~~~~ Change the sys/sysmacros.h header for the more appropriate sys/types.h. Fixes: effe4d6ced88 ("libcamera: camera_manager, pipeline_handler: allow retrieving cameras by device numbers") Reported-by: Madhavan Krishnan <madhavan.krishnan@linaro.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> --- v2: - Added reported-by tag, and reviewed-by tags - Removed #include <sys/sysmacros.h> src/libcamera/include/pipeline_handler.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)