From patchwork Fri Jan 31 16:08:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 2763 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id EE977606E5 for ; Fri, 31 Jan 2020 17:08:52 +0100 (CET) Received: from localhost.localdomain (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4107A71D; Fri, 31 Jan 2020 17:08:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1580486932; bh=VwE3dDNIyBV+lq1ijFymAryrwPVoudK5LtEr8aQ1LiM=; h=From:To:Cc:Subject:Date:From; b=f3/MdxcyyloZ1hMccfgxAnmy4roYqrSS/Nte00bR086yiDFuPEXLU3R68paypOBFN pya59Idaj1QAXBF/K+4AU+0IBZ+1VQK9CtmvmoTO0epsFnXzgLxuh0+r+0XAAQGHO6 6td6opjsG9lsuTR0Sy5+3Vd2fhz5HZZMyU/ybnd0= From: Kieran Bingham To: LibCamera Devel Cc: Kieran Bingham , Madhavan Krishnan , Laurent Pinchart Date: Fri, 31 Jan 2020 16:08:46 +0000 Message-Id: <20200131160846.13084-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2] pipeline_handler: Include system header for dev_t X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jan 2020 16:08:53 -0000 Compiling with gcc 9.2.0-r5 identifies the following compile time failure: FAILED: src/libcamera/4ab8042@@camera@sha/camera.cpp.o c++ -Isrc/libcamera/4ab8042@@camera@sha -Isrc/libcamera -I../src/libcamera -Iinclude -I../include -Isrc/libcamera/include -I../src/libcamera/include -Iinclude/libcamera -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++14 -g -Wno-unused-parameter -include config.h -fPIC -pthread -MD -MQ 'src/libcamera/4ab8042@@camera@sha/camera.cpp.o' -MF 'src/libcamera/4ab8042@@camera@sha/camera.cpp.o.d' -o 'src/libcamera/4ab8042@@camera@sha/camera.cpp.o' -c ../src/libcamera/camera.cpp In file included from ../src/libcamera/camera.cpp:17: ../src/libcamera/include/pipeline_handler.h:91:42: error: 'dev_t' has not been declared 91 | std::unique_ptr data, dev_t devnum = 0); | ^~~~~ Change the sys/sysmacros.h header for the more appropriate sys/types.h. Fixes: effe4d6ced88 ("libcamera: camera_manager, pipeline_handler: allow retrieving cameras by device numbers") Reported-by: Madhavan Krishnan Reviewed-by: Laurent Pinchart Signed-off-by: Kieran Bingham --- v2: - Added reported-by tag, and reviewed-by tags - Removed #include src/libcamera/include/pipeline_handler.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h index a6c1e1fbae38..97157dd75c8a 100644 --- a/src/libcamera/include/pipeline_handler.h +++ b/src/libcamera/include/pipeline_handler.h @@ -12,7 +12,7 @@ #include #include #include -#include +#include #include #include