[RFC] libipa: camera_sensor_helper: Promote some blacklevel values from rpi
diff mbox series

Message ID 20260729154046.207568-1-robert.mader@collabora.com
State New
Headers show
Series
  • [RFC] libipa: camera_sensor_helper: Promote some blacklevel values from rpi
Related show

Commit Message

Robert Mader July 29, 2026, 3:40 p.m. UTC 
These sensors have existing sensor helpers and black level values in the
corresponding tuning files. Lift them up so they can be used by other
IPAs, most importantly the softISP.

Signed-off-by: Robert Mader <robert.mader@collabora.com>
---
 src/ipa/libipa/camera_sensor_helper.cpp | 5 +++++
 1 file changed, 5 insertions(+)

Patch
diff mbox series 

diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp
index cc16e25123d9..139e7dd646ee 100644
--- a/src/ipa/libipa/camera_sensor_helper.cpp
+++ b/src/ipa/libipa/camera_sensor_helper.cpp
@@ -595,6 +595,7 @@  class CameraSensorHelperImx296 : public CameraSensorHelper
 public:
 	CameraSensorHelperImx296()
 	{
+		blackLevel_ = 3840;
 		gain_ = AnalogueGainExp{ 1.0, expGainDb(0.1) };
 	}
 };
@@ -634,6 +635,7 @@  class CameraSensorHelperImx415 : public CameraSensorHelper
 public:
 	CameraSensorHelperImx415()
 	{
+		blackLevel_ = 3840;
 		gain_ = AnalogueGainExp{ 1.0, expGainDb(0.3) };
 	}
 };
@@ -649,6 +651,7 @@  class CameraSensorHelperImx477 : public CameraSensorHelper
 public:
 	CameraSensorHelperImx477()
 	{
+		blackLevel_ = 4096;
 		gain_ = AnalogueGainLinear{ 0, 1024, -1, 1024 };
 	}
 };
@@ -779,6 +782,7 @@  class CameraSensorHelperOv5647 : public CameraSensorHelper
 public:
 	CameraSensorHelperOv5647()
 	{
+		blackLevel_ = 1024;
 		gain_ = AnalogueGainLinear{ 1, 0, 0, 16 };
 	}
 };
@@ -822,6 +826,7 @@  class CameraSensorHelperOv64a40 : public CameraSensorHelper
 public:
 	CameraSensorHelperOv64a40()
 	{
+		blackLevel_ = 4096;
 		gain_ = AnalogueGainLinear{ 1, 0, 0, 128 };
 	}
 };