From patchwork Wed Jul 29 15:40:46 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Mader X-Patchwork-Id: 27522 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 569B0C32FE for ; Wed, 29 Jul 2026 15:41:19 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3BC4067FAF; Wed, 29 Jul 2026 17:41:18 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=collabora.com header.i=robert.mader@collabora.com header.b="FaODfC1r"; dkim-atps=neutral Received: from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com [136.143.188.11]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BA80A67FA9 for ; Wed, 29 Jul 2026 17:41:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; t=1785339673; cv=none; d=zohomail.com; s=zohoarc; b=dJJ39WAIaQdA+qjdGvkcna6l1uUvO6QbgJXKeR8dgqF7hUcPzXIxFJEo+q5VaDbiBmLOZtjzlhTZ76lQkYdVQ+dGchxBjYv+LcB0Rq/ZZJ6gF9JHkjZfi+e3ONeKcFukoDYzWVyRVP89tXOeItJr0kTpSNl1+5Yk+FmjiUkuDx4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785339673; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=3FiSoe0WCodOYmcZjKENA8RN9V4w4UQkuKWkbZ0Z6pM=; b=EO78wwex0+HlM1RT4nocT731vuEHCDbOodtvM9reyPlAE3sBkGW5colTsLQJ/vGQqyQ44w4JZ8KN1HMPposILf2BV6oX1KLIpWiZ/xV06mlghg7JNqeZgC7I1NQdT0IV9vXJPfS/ehCPq1V5a+FDVCTaHTSXZwkyHVTToXfjyE4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=robert.mader@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1785339673; s=zohomail; d=collabora.com; i=robert.mader@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=3FiSoe0WCodOYmcZjKENA8RN9V4w4UQkuKWkbZ0Z6pM=; b=FaODfC1r3PBTrxxhoZ7oMpUORPEzc0+smAGHIvT5OkUb3AV+yFGxaP0e82k4WRTn Uo1k85hqOi1Fq1EkkfL6SCG0Z+UDGt7a3NR5nYQiByiOVacUekJGk7mxyvlkS87SWqv t/R58FWyWTy8FLjPUrXqYURNA4o4ADdDJjIbNs1Y= Received: by mx.zohomail.com with SMTPS id 1785339672148787.1704552930295; Wed, 29 Jul 2026 08:41:12 -0700 (PDT) From: Robert Mader To: libcamera-devel@lists.libcamera.org Cc: Robert Mader Subject: [RFC PATCH] libipa: camera_sensor_helper: Promote some blacklevel values from rpi Date: Wed, 29 Jul 2026 17:40:46 +0200 Message-ID: <20260729154046.207568-1-robert.mader@collabora.com> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" These sensors have existing sensor helpers and black level values in the corresponding tuning files. Lift them up so they can be used by other IPAs, most importantly the softISP. Signed-off-by: Robert Mader --- src/ipa/libipa/camera_sensor_helper.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index cc16e25123d9..139e7dd646ee 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -595,6 +595,7 @@ class CameraSensorHelperImx296 : public CameraSensorHelper public: CameraSensorHelperImx296() { + blackLevel_ = 3840; gain_ = AnalogueGainExp{ 1.0, expGainDb(0.1) }; } }; @@ -634,6 +635,7 @@ class CameraSensorHelperImx415 : public CameraSensorHelper public: CameraSensorHelperImx415() { + blackLevel_ = 3840; gain_ = AnalogueGainExp{ 1.0, expGainDb(0.3) }; } }; @@ -649,6 +651,7 @@ class CameraSensorHelperImx477 : public CameraSensorHelper public: CameraSensorHelperImx477() { + blackLevel_ = 4096; gain_ = AnalogueGainLinear{ 0, 1024, -1, 1024 }; } }; @@ -779,6 +782,7 @@ class CameraSensorHelperOv5647 : public CameraSensorHelper public: CameraSensorHelperOv5647() { + blackLevel_ = 1024; gain_ = AnalogueGainLinear{ 1, 0, 0, 16 }; } }; @@ -822,6 +826,7 @@ class CameraSensorHelperOv64a40 : public CameraSensorHelper public: CameraSensorHelperOv64a40() { + blackLevel_ = 4096; gain_ = AnalogueGainLinear{ 1, 0, 0, 128 }; } };