[v2,4/5] libipa: camera_sensor_helper: Add Mira220
diff mbox series

Message ID 20260724-mira220-v2-4-240003749dd0@ideasonboard.com
State New
Headers show
Series
  • ipa: rpi: Add support for Mira220 RGB version
Related show

Commit Message

Jacopo Mondi July 24, 2026, 3:47 p.m. UTC 
Add a camera sensor helper for the AMS-OSRAM Mira220 sensor.

The black level and gain model have been extracted from the
corresponding helpers for the RaspberryPi IPA.

Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
 src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Kieran Bingham July 24, 2026, 3:53 p.m. UTC | #1 
Quoting Jacopo Mondi (2026-07-24 16:47:43)
> Add a camera sensor helper for the AMS-OSRAM Mira220 sensor.
> 
> The black level and gain model have been extracted from the
> corresponding helpers for the RaspberryPi IPA.
> 
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> ---
>  src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp
> index 9ab7a52f2644..a9877935cb2a 100644
> --- a/src/ipa/libipa/camera_sensor_helper.cpp
> +++ b/src/ipa/libipa/camera_sensor_helper.cpp
> @@ -665,6 +665,17 @@ public:
>  };
>  REGISTER_CAMERA_SENSOR_HELPER("imx708", CameraSensorHelperImx708)
>  
> +class CameraSensorHelperMira220 : public CameraSensorHelper
> +{
> +public:
> +       CameraSensorHelperMira220()
> +       {
> +               blackLevel_ = 2050;

I think this should be 2500 based on the pi tuning files:

With that

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> +               gain_ = AnalogueGainLinear{ 0, 2048, -1, 2048 };
> +       }
> +};
> +REGISTER_CAMERA_SENSOR_HELPER("mira220", CameraSensorHelperMira220)
> +
>  class CameraSensorHelperOv2685 : public CameraSensorHelper
>  {
>  public:
> 
> -- 
> 2.54.0
>

Patch
diff mbox series 

diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp
index 9ab7a52f2644..a9877935cb2a 100644
--- a/src/ipa/libipa/camera_sensor_helper.cpp
+++ b/src/ipa/libipa/camera_sensor_helper.cpp
@@ -665,6 +665,17 @@  public:
 };
 REGISTER_CAMERA_SENSOR_HELPER("imx708", CameraSensorHelperImx708)
 
+class CameraSensorHelperMira220 : public CameraSensorHelper
+{
+public:
+	CameraSensorHelperMira220()
+	{
+		blackLevel_ = 2050;
+		gain_ = AnalogueGainLinear{ 0, 2048, -1, 2048 };
+	}
+};
+REGISTER_CAMERA_SENSOR_HELPER("mira220", CameraSensorHelperMira220)
+
 class CameraSensorHelperOv2685 : public CameraSensorHelper
 {
 public: