| Message ID | 20260724-mira220-v2-4-240003749dd0@ideasonboard.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series |
|
| Related | show |
Quoting Jacopo Mondi (2026-07-24 16:47:43) > Add a camera sensor helper for the AMS-OSRAM Mira220 sensor. > > The black level and gain model have been extracted from the > corresponding helpers for the RaspberryPi IPA. > > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > --- > src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp > index 9ab7a52f2644..a9877935cb2a 100644 > --- a/src/ipa/libipa/camera_sensor_helper.cpp > +++ b/src/ipa/libipa/camera_sensor_helper.cpp > @@ -665,6 +665,17 @@ public: > }; > REGISTER_CAMERA_SENSOR_HELPER("imx708", CameraSensorHelperImx708) > > +class CameraSensorHelperMira220 : public CameraSensorHelper > +{ > +public: > + CameraSensorHelperMira220() > + { > + blackLevel_ = 2050; I think this should be 2500 based on the pi tuning files: With that Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > + gain_ = AnalogueGainLinear{ 0, 2048, -1, 2048 }; > + } > +}; > +REGISTER_CAMERA_SENSOR_HELPER("mira220", CameraSensorHelperMira220) > + > class CameraSensorHelperOv2685 : public CameraSensorHelper > { > public: > > -- > 2.54.0 >
On Fri, Jul 24, 2026 at 04:53:22PM +0100, Kieran Bingham wrote: > Quoting Jacopo Mondi (2026-07-24 16:47:43) > > Add a camera sensor helper for the AMS-OSRAM Mira220 sensor. > > > > The black level and gain model have been extracted from the > > corresponding helpers for the RaspberryPi IPA. > > > > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > > --- > > src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp > > index 9ab7a52f2644..a9877935cb2a 100644 > > --- a/src/ipa/libipa/camera_sensor_helper.cpp > > +++ b/src/ipa/libipa/camera_sensor_helper.cpp > > @@ -665,6 +665,17 @@ public: > > }; > > REGISTER_CAMERA_SENSOR_HELPER("imx708", CameraSensorHelperImx708) > > > > +class CameraSensorHelperMira220 : public CameraSensorHelper > > +{ > > +public: > > + CameraSensorHelperMira220() > > + { > > + blackLevel_ = 2050; > > I think this should be 2500 based on the pi tuning files: Neither 2050 nor 2500 are divisible by 16, so something is likely wrong. > With that > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > + gain_ = AnalogueGainLinear{ 0, 2048, -1, 2048 }; > > + } > > +}; > > +REGISTER_CAMERA_SENSOR_HELPER("mira220", CameraSensorHelperMira220) > > + > > class CameraSensorHelperOv2685 : public CameraSensorHelper > > { > > public:
diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index 9ab7a52f2644..a9877935cb2a 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -665,6 +665,17 @@ public: }; REGISTER_CAMERA_SENSOR_HELPER("imx708", CameraSensorHelperImx708) +class CameraSensorHelperMira220 : public CameraSensorHelper +{ +public: + CameraSensorHelperMira220() + { + blackLevel_ = 2050; + gain_ = AnalogueGainLinear{ 0, 2048, -1, 2048 }; + } +}; +REGISTER_CAMERA_SENSOR_HELPER("mira220", CameraSensorHelperMira220) + class CameraSensorHelperOv2685 : public CameraSensorHelper { public:
Add a camera sensor helper for the AMS-OSRAM Mira220 sensor. The black level and gain model have been extracted from the corresponding helpers for the RaspberryPi IPA. Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> --- src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++ 1 file changed, 11 insertions(+)