[v2,1/8] ipa: rpi: Drop unused params argument from platformPrepareIsp()
diff mbox series

Message ID 20260722-pi4-upstream-v2-1-eb44d3c6fd92@ideasonboard.com
State New
Headers show
Series
  • Raspberry Pi: Update VC4 pipeline for mainline
Related show

Commit Message

Jai Luthra July 22, 2026, 11:23 a.m. UTC 
In IPABase::platformPrepareIsp() we pass PrepareParams but none of the
IPAs (vc4 and pisp) use them. So drop it.

Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
---
 src/ipa/rpi/common/ipa_base.cpp | 2 +-
 src/ipa/rpi/common/ipa_base.h   | 3 +--
 src/ipa/rpi/pisp/pisp.cpp       | 6 ++----
 src/ipa/rpi/vc4/vc4.cpp         | 5 ++---
 4 files changed, 6 insertions(+), 10 deletions(-)

Patch
diff mbox series 

diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp
index dacafa578..e3f7b99a8 100644
--- a/src/ipa/rpi/common/ipa_base.cpp
+++ b/src/ipa/rpi/common/ipa_base.cpp
@@ -507,7 +507,7 @@  void IpaBase::prepareIsp(const PrepareParams &params)
 	if (processPending_) {
 		controller_.prepare(&rpiMetadata);
 		/* Actually prepare the ISP parameters for the frame. */
-		platformPrepareIsp(params, rpiMetadata);
+		platformPrepareIsp(rpiMetadata);
 		platformPrepareAgc(rpiMetadata);
 	} else
 		platformPrepareAgc(rpiMetadata);
diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h
index 90f018b28..f4157e9ec 100644
--- a/src/ipa/rpi/common/ipa_base.h
+++ b/src/ipa/rpi/common/ipa_base.h
@@ -87,8 +87,7 @@  private:
 	virtual int32_t platformStart(const ControlList &controls, StartResult *result) = 0;
 	virtual int32_t platformConfigure(const ConfigParams &params, ConfigResult *result) = 0;
 
-	virtual void platformPrepareIsp(const PrepareParams &params,
-					RPiController::Metadata &rpiMetadata) = 0;
+	virtual void platformPrepareIsp(RPiController::Metadata &rpiMetadata) = 0;
 	virtual void platformPrepareAgc(RPiController::Metadata &rpiMetadata) = 0;
 	virtual RPiController::StatisticsPtr platformProcessStats(Span<uint8_t> mem) = 0;
 
diff --git a/src/ipa/rpi/pisp/pisp.cpp b/src/ipa/rpi/pisp/pisp.cpp
index fd28fc385..025103808 100644
--- a/src/ipa/rpi/pisp/pisp.cpp
+++ b/src/ipa/rpi/pisp/pisp.cpp
@@ -232,8 +232,7 @@  private:
 	int32_t platformStart(const ControlList &controls, StartResult *result) override;
 	int32_t platformConfigure(const ConfigParams &params, ConfigResult *result) override;
 
-	void platformPrepareIsp(const PrepareParams &params,
-				RPiController::Metadata &rpiMetadata) override;
+	void platformPrepareIsp(RPiController::Metadata &rpiMetadata) override;
 	void platformPrepareAgc(RPiController::Metadata &rpiMetadata) override;
 	RPiController::StatisticsPtr platformProcessStats(Span<uint8_t> mem) override;
 
@@ -354,8 +353,7 @@  int32_t IpaPiSP::platformConfigure([[maybe_unused]] const ConfigParams &params,
 	return 0;
 }
 
-void IpaPiSP::platformPrepareIsp([[maybe_unused]] const PrepareParams &params,
-				 RPiController::Metadata &rpiMetadata)
+void IpaPiSP::platformPrepareIsp(RPiController::Metadata &rpiMetadata)
 {
 	std::scoped_lock<RPiController::Metadata> l(rpiMetadata);
 
diff --git a/src/ipa/rpi/vc4/vc4.cpp b/src/ipa/rpi/vc4/vc4.cpp
index b6ca44e7a..052204d25 100644
--- a/src/ipa/rpi/vc4/vc4.cpp
+++ b/src/ipa/rpi/vc4/vc4.cpp
@@ -59,7 +59,7 @@  private:
 	int32_t platformStart(const ControlList &controls, StartResult *result) override;
 	int32_t platformConfigure(const ConfigParams &params, ConfigResult *result) override;
 
-	void platformPrepareIsp(const PrepareParams &params, RPiController::Metadata &rpiMetadata) override;
+	void platformPrepareIsp(RPiController::Metadata &rpiMetadata) override;
 	void platformPrepareAgc([[maybe_unused]] RPiController::Metadata &rpiMetadata) override;
 	RPiController::StatisticsPtr platformProcessStats(Span<uint8_t> mem) override;
 
@@ -144,8 +144,7 @@  int32_t IpaVc4::platformConfigure(const ConfigParams &params, [[maybe_unused]] C
 	return 0;
 }
 
-void IpaVc4::platformPrepareIsp([[maybe_unused]] const PrepareParams &params,
-				RPiController::Metadata &rpiMetadata)
+void IpaVc4::platformPrepareIsp(RPiController::Metadata &rpiMetadata)
 {
 	ControlList &ctrls = ctrls_;