From patchwork Wed Jul 22 11:23:17 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jai Luthra X-Patchwork-Id: 27436 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id F2809BDE17 for ; Wed, 22 Jul 2026 11:24:45 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A323967E8A; Wed, 22 Jul 2026 13:24:45 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="a6c9/H1P"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 99FDC67E8A for ; Wed, 22 Jul 2026 13:24:43 +0200 (CEST) Received: from mail.ideasonboard.com (unknown [IPv6:2401:4900:1c68:25d4:fa24:78d1:31:7a56]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3B9D0227; Wed, 22 Jul 2026 13:23:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1784719423; bh=lxR3DJXyq6m0F90hz/jSuiaOQi61Nmv7gwuhz0/38h8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=a6c9/H1PMc1EIGL6sYp+M6GJGukdp+ThsI834XyV9RY2T7IIYQZeRjSRW+FYDVY3I Q5H1Rhfr90ypFqURGqBjTnTw6O32VfWryrKZalqp8eOb0OQ2y1JMqn/CgeNG7MY3Ni AOegbwBwi3grMY2wzRPfZJxTMBvV+3rkG3BggP04= From: Jai Luthra Date: Wed, 22 Jul 2026 16:53:17 +0530 Subject: [PATCH v2 1/8] ipa: rpi: Drop unused params argument from platformPrepareIsp() MIME-Version: 1.0 Message-Id: <20260722-pi4-upstream-v2-1-eb44d3c6fd92@ideasonboard.com> References: <20260722-pi4-upstream-v2-0-eb44d3c6fd92@ideasonboard.com> In-Reply-To: <20260722-pi4-upstream-v2-0-eb44d3c6fd92@ideasonboard.com> To: libcamera-devel@lists.libcamera.org Cc: Naushir Patuck , David Plowman , Laurent Pinchart , Kieran Bingham , Jacopo Mondi , Daniel Scally , Jai Luthra X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3922; i=jai.luthra@ideasonboard.com; h=from:subject:message-id; bh=lxR3DJXyq6m0F90hz/jSuiaOQi61Nmv7gwuhz0/38h8=; b=owEBbQKS/ZANAwAKAUPekfkkmnFFAcsmYgBqYKhojL1BhHXdBTLlF13U5w/Ztw4lL0WL33mEZ BzoJXfQS3mJAjMEAAEKAB0WIQRN4NgY5dV16NRar8VD3pH5JJpxRQUCamCoaAAKCRBD3pH5JJpx RTxKEACj11Oz7P9paHbrInOQaRItIPackj34ewWIhn4TD11GOK7aiUfOujwIfG3sPZLBhN9a/Ui PTqLOJhiySqxqstJUzYL6WDKk6T9CvrJqvOcBTjl6GlmYMEtXrZinKyOD3CO10ClIuwINQkjUOD UCL1vqZMJZ0a9Qy0wIVSYOm6v2IJFOS6f48mQlv8CkbpDvb56npjjKYZ7EN2E1xttYWzDCMZsEi LjrHqEznVTbY+W/RdzIxkvAeqWj5nFUStJFUlBhwo1Agtozv3Ez9Li0EG+8uE9SvMFoFGJ+uNx+ uB4uNd9IieqEa0A7sNNPfdL0Wg8vFrmzWCI/vA7s5P6T8OHmn4Xe70jdQZYqnV4ypXf4XgxqNUe grP0LTLEuao38WvCv4W09rrvZizdWzhXPLW/DzcBe6RelOegLXZH++B54mDoCEGbVUvLZvQgSe+ sWSGkJIzimoZSWNHCBgMyfdm8XkRxIw9wYvoXNYJHknBWOxX6260zBk/nAGfj+X/rFYZl4weYYs I3GzpE7tJMKbf8lGsXjaZUytxkItfYIdJeSyI5KCXSID6nVQUrorVF3GPkT8nF9STuwFRI74MwD N0gjO3x8gOPm5qCVrAJxZK89WWtrfTvXw4iihJsGS3yO00MWl4mPh4RSeQ6uxFc8jG95CVdYRpH /4pNPFyhBGyNaOw== X-Developer-Key: i=jai.luthra@ideasonboard.com; a=openpgp; fpr=4DE0D818E5D575E8D45AAFC543DE91F9249A7145 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" In IPABase::platformPrepareIsp() we pass PrepareParams but none of the IPAs (vc4 and pisp) use them. So drop it. Signed-off-by: Jai Luthra --- src/ipa/rpi/common/ipa_base.cpp | 2 +- src/ipa/rpi/common/ipa_base.h | 3 +-- src/ipa/rpi/pisp/pisp.cpp | 6 ++---- src/ipa/rpi/vc4/vc4.cpp | 5 ++--- 4 files changed, 6 insertions(+), 10 deletions(-) diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp index dacafa578..e3f7b99a8 100644 --- a/src/ipa/rpi/common/ipa_base.cpp +++ b/src/ipa/rpi/common/ipa_base.cpp @@ -507,7 +507,7 @@ void IpaBase::prepareIsp(const PrepareParams ¶ms) if (processPending_) { controller_.prepare(&rpiMetadata); /* Actually prepare the ISP parameters for the frame. */ - platformPrepareIsp(params, rpiMetadata); + platformPrepareIsp(rpiMetadata); platformPrepareAgc(rpiMetadata); } else platformPrepareAgc(rpiMetadata); diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h index 90f018b28..f4157e9ec 100644 --- a/src/ipa/rpi/common/ipa_base.h +++ b/src/ipa/rpi/common/ipa_base.h @@ -87,8 +87,7 @@ private: virtual int32_t platformStart(const ControlList &controls, StartResult *result) = 0; virtual int32_t platformConfigure(const ConfigParams ¶ms, ConfigResult *result) = 0; - virtual void platformPrepareIsp(const PrepareParams ¶ms, - RPiController::Metadata &rpiMetadata) = 0; + virtual void platformPrepareIsp(RPiController::Metadata &rpiMetadata) = 0; virtual void platformPrepareAgc(RPiController::Metadata &rpiMetadata) = 0; virtual RPiController::StatisticsPtr platformProcessStats(Span mem) = 0; diff --git a/src/ipa/rpi/pisp/pisp.cpp b/src/ipa/rpi/pisp/pisp.cpp index fd28fc385..025103808 100644 --- a/src/ipa/rpi/pisp/pisp.cpp +++ b/src/ipa/rpi/pisp/pisp.cpp @@ -232,8 +232,7 @@ private: int32_t platformStart(const ControlList &controls, StartResult *result) override; int32_t platformConfigure(const ConfigParams ¶ms, ConfigResult *result) override; - void platformPrepareIsp(const PrepareParams ¶ms, - RPiController::Metadata &rpiMetadata) override; + void platformPrepareIsp(RPiController::Metadata &rpiMetadata) override; void platformPrepareAgc(RPiController::Metadata &rpiMetadata) override; RPiController::StatisticsPtr platformProcessStats(Span mem) override; @@ -354,8 +353,7 @@ int32_t IpaPiSP::platformConfigure([[maybe_unused]] const ConfigParams ¶ms, return 0; } -void IpaPiSP::platformPrepareIsp([[maybe_unused]] const PrepareParams ¶ms, - RPiController::Metadata &rpiMetadata) +void IpaPiSP::platformPrepareIsp(RPiController::Metadata &rpiMetadata) { std::scoped_lock l(rpiMetadata); diff --git a/src/ipa/rpi/vc4/vc4.cpp b/src/ipa/rpi/vc4/vc4.cpp index b6ca44e7a..052204d25 100644 --- a/src/ipa/rpi/vc4/vc4.cpp +++ b/src/ipa/rpi/vc4/vc4.cpp @@ -59,7 +59,7 @@ private: int32_t platformStart(const ControlList &controls, StartResult *result) override; int32_t platformConfigure(const ConfigParams ¶ms, ConfigResult *result) override; - void platformPrepareIsp(const PrepareParams ¶ms, RPiController::Metadata &rpiMetadata) override; + void platformPrepareIsp(RPiController::Metadata &rpiMetadata) override; void platformPrepareAgc([[maybe_unused]] RPiController::Metadata &rpiMetadata) override; RPiController::StatisticsPtr platformProcessStats(Span mem) override; @@ -144,8 +144,7 @@ int32_t IpaVc4::platformConfigure(const ConfigParams ¶ms, [[maybe_unused]] C return 0; } -void IpaVc4::platformPrepareIsp([[maybe_unused]] const PrepareParams ¶ms, - RPiController::Metadata &rpiMetadata) +void IpaVc4::platformPrepareIsp(RPiController::Metadata &rpiMetadata) { ControlList &ctrls = ctrls_;