[v3,3/4] ipa: ipa-sign: Sign IPA according to the signature algorithm of the key
diff mbox series

Message ID 20260519030020.408693-4-hpa@redhat.com
State Changes Requested
Headers show
Series
  • Implement ML-DSA-65 for Post-Quantum Cryptographic compliance
Related show

Commit Message

Kate Hsuan May 19, 2026, 3 a.m. UTC
Sign IPA according to the signature algorithm of the key.

Signed-off-by: Kate Hsuan <hpa@redhat.com>
---
 src/ipa/ipa-sign.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Laurent Pinchart June 15, 2026, 2:47 p.m. UTC | #1
Hi Kate,

Thank you for the patch.

On Tue, May 19, 2026 at 11:00:19AM +0800, Kate Hsuan wrote:
> Sign IPA according to the signature algorithm of the key.
> 
> Signed-off-by: Kate Hsuan <hpa@redhat.com>

Same here, pkeyutl has been there forever.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/ipa/ipa-sign.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/ipa-sign.sh b/src/ipa/ipa-sign.sh
> index 69024213..b7c7c47b 100755
> --- a/src/ipa/ipa-sign.sh
> +++ b/src/ipa/ipa-sign.sh
> @@ -10,4 +10,4 @@ key="$1"
>  input="$2"
>  output="$3"
>  
> -openssl dgst -sha256 -sign "${key}" -out "${output}" "${input}"
> +openssl pkeyutl -sign -inkey "${key}" -rawin -in "${input}" -out "${output}"

Patch
diff mbox series

diff --git a/src/ipa/ipa-sign.sh b/src/ipa/ipa-sign.sh
index 69024213..b7c7c47b 100755
--- a/src/ipa/ipa-sign.sh
+++ b/src/ipa/ipa-sign.sh
@@ -10,4 +10,4 @@  key="$1"
 input="$2"
 output="$3"
 
-openssl dgst -sha256 -sign "${key}" -out "${output}" "${input}"
+openssl pkeyutl -sign -inkey "${key}" -rawin -in "${input}" -out "${output}"