| Message ID | 20260512144520.171290-3-laurent.pinchart@ideasonboard.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
2026. 05. 12. 16:45 keltezéssel, Laurent Pinchart írta: > The compilation of release builds, ASan and debugstl is known to cause > lots of positives with various versions of gcc. One of them is already > worked around by disabling ASan for gcc 12 release builds. More will be > triggered by release builds using newer gcc versions. > > While some of the false positives can be worked around in libcamera, > others with gcc 14 and gcc 15 would require more intrusive changes. > Disabling either ASan or debugstl is enough to avoid the false > positives. > > Given that distributions are not expected to enable ASan or debugstl in > their packages, it is important to test release compilation without > those options as that will be the main use case. If we later find value > in having release builds with either ASan or debugstl in CI, new jobs > will be added. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- Looks ok to me. Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > gitlab-ci.yml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gitlab-ci.yml b/gitlab-ci.yml > index e5b3925e49d5..f9496fcdc80c 100644 > --- a/gitlab-ci.yml > +++ b/gitlab-ci.yml > @@ -186,12 +186,10 @@ build-full:debian:12: > BUILD_TYPE: release > CC: gcc-12 > CXX: g++-12 > - # gcc 12.2.0 has a bug that triggers a false positive warning with ASan > - # in release builds (see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105562). > - # Disable the address sanitizer for now. > MESON_OPTIONS: >- > ${MESON_ALL_OPTIONS} > -D b_sanitize=none > + -D cpp_debugstl=false > - ARCH: amd64 > CC: clang > CXX: clang++ > @@ -206,6 +204,8 @@ build-full:debian:12: > MESON_OPTIONS: >- > ${MESON_ALL_OPTIONS} > ${MESON_CLANG_LIBCPP_OPTIONS} > + -D b_sanitize=none > + -D cpp_debugstl=false > -D qcam=disabled > > build-full:debian:13:
diff --git a/gitlab-ci.yml b/gitlab-ci.yml index e5b3925e49d5..f9496fcdc80c 100644 --- a/gitlab-ci.yml +++ b/gitlab-ci.yml @@ -186,12 +186,10 @@ build-full:debian:12: BUILD_TYPE: release CC: gcc-12 CXX: g++-12 - # gcc 12.2.0 has a bug that triggers a false positive warning with ASan - # in release builds (see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105562). - # Disable the address sanitizer for now. MESON_OPTIONS: >- ${MESON_ALL_OPTIONS} -D b_sanitize=none + -D cpp_debugstl=false - ARCH: amd64 CC: clang CXX: clang++ @@ -206,6 +204,8 @@ build-full:debian:12: MESON_OPTIONS: >- ${MESON_ALL_OPTIONS} ${MESON_CLANG_LIBCPP_OPTIONS} + -D b_sanitize=none + -D cpp_debugstl=false -D qcam=disabled build-full:debian:13:
The compilation of release builds, ASan and debugstl is known to cause lots of positives with various versions of gcc. One of them is already worked around by disabling ASan for gcc 12 release builds. More will be triggered by release builds using newer gcc versions. While some of the false positives can be worked around in libcamera, others with gcc 14 and gcc 15 would require more intrusive changes. Disabling either ASan or debugstl is enough to avoid the false positives. Given that distributions are not expected to enable ASan or debugstl in their packages, it is important to test release compilation without those options as that will be the main use case. If we later find value in having release builds with either ASan or debugstl in CI, new jobs will be added. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- gitlab-ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)