| Message ID | 20260512144520.171290-2-laurent.pinchart@ideasonboard.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
2026. 05. 12. 16:45 keltezéssel, Laurent Pinchart írta: > Debug build type is the default for all full builds, as specified by > .build-full:debian. There's no need to specify it manually again in jobs > that extend .build-full:debian. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- The "debug" text is displayed in the job title on the gitlab ui, I think that's somewhat useful. Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > gitlab-ci.yml | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/gitlab-ci.yml b/gitlab-ci.yml > index f887e3b6c221..e5b3925e49d5 100644 > --- a/gitlab-ci.yml > +++ b/gitlab-ci.yml > @@ -180,7 +180,6 @@ build-full:debian:12: > parallel: > matrix: > - ARCH: amd64 > - BUILD_TYPE: debug > CC: gcc-12 > CXX: g++-12 > - ARCH: amd64 > @@ -194,7 +193,6 @@ build-full:debian:12: > ${MESON_ALL_OPTIONS} > -D b_sanitize=none > - ARCH: amd64 > - BUILD_TYPE: debug > CC: clang > CXX: clang++ > MESON_OPTIONS: >-
On Tue, May 12, 2026 at 05:52:01PM +0200, Barnabás Pőcze wrote: > 2026. 05. 12. 16:45 keltezéssel, Laurent Pinchart írta: > > Debug build type is the default for all full builds, as specified by > > .build-full:debian. There's no need to specify it manually again in jobs > > that extend .build-full:debian. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > The "debug" text is displayed in the job title on the gitlab ui, > I think that's somewhat useful. Would you prefer if I dropped "BUILD_TYPE: debug" from .build-full:debian, and specified it manually everywhere ? > Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > > > gitlab-ci.yml | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/gitlab-ci.yml b/gitlab-ci.yml > > index f887e3b6c221..e5b3925e49d5 100644 > > --- a/gitlab-ci.yml > > +++ b/gitlab-ci.yml > > @@ -180,7 +180,6 @@ build-full:debian:12: > > parallel: > > matrix: > > - ARCH: amd64 > > - BUILD_TYPE: debug > > CC: gcc-12 > > CXX: g++-12 > > - ARCH: amd64 > > @@ -194,7 +193,6 @@ build-full:debian:12: > > ${MESON_ALL_OPTIONS} > > -D b_sanitize=none > > - ARCH: amd64 > > - BUILD_TYPE: debug > > CC: clang > > CXX: clang++ > > MESON_OPTIONS: >-
2026. 05. 12. 21:18 keltezéssel, Laurent Pinchart írta: > On Tue, May 12, 2026 at 05:52:01PM +0200, Barnabás Pőcze wrote: >> 2026. 05. 12. 16:45 keltezéssel, Laurent Pinchart írta: >>> Debug build type is the default for all full builds, as specified by >>> .build-full:debian. There's no need to specify it manually again in jobs >>> that extend .build-full:debian. >>> >>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >>> --- >> >> The "debug" text is displayed in the job title on the gitlab ui, >> I think that's somewhat useful. > > Would you prefer if I dropped "BUILD_TYPE: debug" from > .build-full:debian, and specified it manually everywhere ? I don't really have a preference, I don't think the missing label will be a big issue. > >> Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> >> >>> gitlab-ci.yml | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/gitlab-ci.yml b/gitlab-ci.yml >>> index f887e3b6c221..e5b3925e49d5 100644 >>> --- a/gitlab-ci.yml >>> +++ b/gitlab-ci.yml >>> @@ -180,7 +180,6 @@ build-full:debian:12: >>> parallel: >>> matrix: >>> - ARCH: amd64 >>> - BUILD_TYPE: debug >>> CC: gcc-12 >>> CXX: g++-12 >>> - ARCH: amd64 >>> @@ -194,7 +193,6 @@ build-full:debian:12: >>> ${MESON_ALL_OPTIONS} >>> -D b_sanitize=none >>> - ARCH: amd64 >>> - BUILD_TYPE: debug >>> CC: clang >>> CXX: clang++ >>> MESON_OPTIONS: >- > > -- > Regards, > > Laurent Pinchart
diff --git a/gitlab-ci.yml b/gitlab-ci.yml index f887e3b6c221..e5b3925e49d5 100644 --- a/gitlab-ci.yml +++ b/gitlab-ci.yml @@ -180,7 +180,6 @@ build-full:debian:12: parallel: matrix: - ARCH: amd64 - BUILD_TYPE: debug CC: gcc-12 CXX: g++-12 - ARCH: amd64 @@ -194,7 +193,6 @@ build-full:debian:12: ${MESON_ALL_OPTIONS} -D b_sanitize=none - ARCH: amd64 - BUILD_TYPE: debug CC: clang CXX: clang++ MESON_OPTIONS: >-
Debug build type is the default for all full builds, as specified by .build-full:debian. There's no need to specify it manually again in jobs that extend .build-full:debian. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- gitlab-ci.yml | 2 -- 1 file changed, 2 deletions(-)