[3/6] utils: update-kernel-headers: Add drm/drm.h and drm/drm_mode.h
diff mbox series

Message ID 20260504000431.1340150-4-laurent.pinchart@ideasonboard.com
State New
Headers show
Series
  • libcamera: kernel headers update
Related show

Commit Message

Laurent Pinchart May 4, 2026, 12:04 a.m. UTC
The drm_fourcc.h header includes "drm.h", which in turn includes
"drm_mode.h". We carry a copy of the first header, but not of the last
two. The only reason this does not cause any issue is because the
drm_fourcc.h copy is not used.

In preparation for including drm_fourcc.h in source files, import the
drm.h and drm_mode.h headers.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 utils/update-kernel-headers.sh | 2 ++
 1 file changed, 2 insertions(+)

Comments

Kieran Bingham May 4, 2026, 8:44 a.m. UTC | #1
Quoting Laurent Pinchart (2026-05-04 01:04:28)
> The drm_fourcc.h header includes "drm.h", which in turn includes
> "drm_mode.h". We carry a copy of the first header, but not of the last
> two. The only reason this does not cause any issue is because the
> drm_fourcc.h copy is not used.
> 
> In preparation for including drm_fourcc.h in source files, import the
> drm.h and drm_mode.h headers.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  utils/update-kernel-headers.sh | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/utils/update-kernel-headers.sh b/utils/update-kernel-headers.sh
> index 93599dfe5d52..9f3a79ec6999 100755
> --- a/utils/update-kernel-headers.sh
> +++ b/utils/update-kernel-headers.sh
> @@ -46,7 +46,9 @@ set +e
>  
>  # Copy the headers
>  headers="
> +       drm/drm.h
>         drm/drm_fourcc.h
> +       drm/drm_mode.h
>         linux/dma-buf.h
>         linux/dma-heap.h
>         linux/dw100.h
> -- 
> Regards,
> 
> Laurent Pinchart
>
Barnabás Pőcze May 4, 2026, 9:12 a.m. UTC | #2
2026. 05. 04. 2:04 keltezéssel, Laurent Pinchart írta:
> The drm_fourcc.h header includes "drm.h", which in turn includes
> "drm_mode.h". We carry a copy of the first header, but not of the last
> two. The only reason this does not cause any issue is because the
> drm_fourcc.h copy is not used.
> 
> In preparation for including drm_fourcc.h in source files, import the
> drm.h and drm_mode.h headers.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---

Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>


>   utils/update-kernel-headers.sh | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/utils/update-kernel-headers.sh b/utils/update-kernel-headers.sh
> index 93599dfe5d52..9f3a79ec6999 100755
> --- a/utils/update-kernel-headers.sh
> +++ b/utils/update-kernel-headers.sh
> @@ -46,7 +46,9 @@ set +e
>   
>   # Copy the headers
>   headers="
> +	drm/drm.h
>   	drm/drm_fourcc.h
> +	drm/drm_mode.h
>   	linux/dma-buf.h
>   	linux/dma-heap.h
>   	linux/dw100.h

Patch
diff mbox series

diff --git a/utils/update-kernel-headers.sh b/utils/update-kernel-headers.sh
index 93599dfe5d52..9f3a79ec6999 100755
--- a/utils/update-kernel-headers.sh
+++ b/utils/update-kernel-headers.sh
@@ -46,7 +46,9 @@  set +e
 
 # Copy the headers
 headers="
+	drm/drm.h
 	drm/drm_fourcc.h
+	drm/drm_mode.h
 	linux/dma-buf.h
 	linux/dma-heap.h
 	linux/dw100.h