[v2,6/7] libcamera: mali-c55: Fix sensor size computation
diff mbox series

Message ID 20251210-mali-cru-v2-6-e26421de202b@ideasonboard.com
State New
Headers show
Series
  • libcamera: mali-c55: Add support for memory-to-memory
Related show

Commit Message

Jacopo Mondi Dec. 10, 2025, 2:39 p.m. UTC 
The sensor size computation routine doesn't work well. Even if a
more appriate size for a sensor is available, the largest one is
always selected.

Fix the size computation procedure which has an inverted assignment.

Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
Tested-by: Daniel Scally <dan.scally@ideasonboard.com>
---
 src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Barnabás Pőcze Dec. 18, 2025, 12:13 p.m. UTC | #1 
Hi

2025. 12. 10. 15:39 keltezéssel, Jacopo Mondi írta:
> The sensor size computation routine doesn't work well. Even if a
> more appriate size for a sensor is available, the largest one is
> always selected.
> 
> Fix the size computation procedure which has an inverted assignment.
> 
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
> Tested-by: Daniel Scally <dan.scally@ideasonboard.com>
> ---

Please see my comments on the previous version: https://patchwork.libcamera.org/patch/25376/


Regards,
Barnabás Pőcze

>   src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp
> index 83cb10af5d3c0588b25e4a3190f561f09627d239..24369a341db567bc431a4bd2aecfd6865c676347 100644
> --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp
> +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp
> @@ -749,7 +749,7 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()
>   				std::abs(static_cast<int>(minSensorSize.height) -
>   					 static_cast<int>(size.height));
>   		if (dist < distance) {
> -			dist = distance;
> +			distance = dist;
>   			bestSize = size;
>   		}
>   	}
>

Patch
diff mbox series 

diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp
index 83cb10af5d3c0588b25e4a3190f561f09627d239..24369a341db567bc431a4bd2aecfd6865c676347 100644
--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp
+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp
@@ -749,7 +749,7 @@  CameraConfiguration::Status MaliC55CameraConfiguration::validate()
 				std::abs(static_cast<int>(minSensorSize.height) -
 					 static_cast<int>(size.height));
 		if (dist < distance) {
-			dist = distance;
+			distance = dist;
 			bestSize = size;
 		}
 	}