[v1,17/35] ipa: rkisp1: agc: Fix vblank, when computeParams prepare is not called
diff mbox series

Message ID 20251024085130.995967-18-stefan.klug@ideasonboard.com
State New
Headers show
Series
  • rkisp1: pipeline rework for PFC
Related show

Commit Message

Stefan Klug Oct. 24, 2025, 8:50 a.m. UTC
In raw capture mode, prepare() is not called at all. Ensure that vblank
is still calculated corresctly.

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
---
 src/ipa/rkisp1/algorithms/agc.cpp | 3 +++
 1 file changed, 3 insertions(+)

Comments

Paul Elder Jan. 22, 2026, 9:16 a.m. UTC | #1
Quoting Stefan Klug (2025-10-24 17:50:41)
> In raw capture mode, prepare() is not called at all. Ensure that vblank
> is still calculated corresctly.

s/corresctly/correctly/

> 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>

I'd prefer this squashed with the previous patch.

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  src/ipa/rkisp1/algorithms/agc.cpp | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp
> index 5ce77b7672f2..7c9538f95cbe 100644
> --- a/src/ipa/rkisp1/algorithms/agc.cpp
> +++ b/src/ipa/rkisp1/algorithms/agc.cpp
> @@ -340,6 +340,9 @@ void Agc::queueRequest(IPAContext &context,
>         }
>         frameContext.agc.minFrameDuration = agc.minFrameDuration;
>         frameContext.agc.maxFrameDuration = agc.maxFrameDuration;
> +
> +       /* V-blank needs to be valid for the start controls handling. Update it. */
> +       processFrameDuration(context, frameContext);
>  }
>  
>  /**
> -- 
> 2.48.1
>

Patch
diff mbox series

diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp
index 5ce77b7672f2..7c9538f95cbe 100644
--- a/src/ipa/rkisp1/algorithms/agc.cpp
+++ b/src/ipa/rkisp1/algorithms/agc.cpp
@@ -340,6 +340,9 @@  void Agc::queueRequest(IPAContext &context,
 	}
 	frameContext.agc.minFrameDuration = agc.minFrameDuration;
 	frameContext.agc.maxFrameDuration = agc.maxFrameDuration;
+
+	/* V-blank needs to be valid for the start controls handling. Update it. */
+	processFrameDuration(context, frameContext);
 }
 
 /**