[v1,06/35] pipeline: rkisp1: Include frame number when pushing to delayed controls
diff mbox series

Message ID 20251024085130.995967-7-stefan.klug@ideasonboard.com
State New
Headers show
Series
  • rkisp1: pipeline rework for PFC
Related show

Commit Message

Stefan Klug Oct. 24, 2025, 8:50 a.m. UTC
Pass the frame number when pushing to delayed controls, to ease further
development.

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
---
 src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Paul Elder Jan. 22, 2026, 9:15 a.m. UTC | #1
Quoting Stefan Klug (2025-10-24 17:50:30)
> Pass the frame number when pushing to delayed controls, to ease further
> development.
> 
> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index fef6e23e39b7..17250cbd5ae6 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -524,10 +524,10 @@ void RkISP1CameraData::paramsComputed(unsigned int frame, unsigned int bytesused
>                 selfPath_->queueBuffer(info->selfPathBuffer);
>  }
>  
> -void RkISP1CameraData::setSensorControls([[maybe_unused]] unsigned int frame,
> +void RkISP1CameraData::setSensorControls(unsigned int frame,
>                                          const ControlList &sensorControls)
>  {
> -       delayedCtrls_->push(sensorControls);
> +       delayedCtrls_->push(frame, sensorControls);
>  }
>  
>  void RkISP1CameraData::metadataReady(unsigned int frame, const ControlList &metadata)
> -- 
> 2.48.1
>

Patch
diff mbox series

diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
index fef6e23e39b7..17250cbd5ae6 100644
--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
@@ -524,10 +524,10 @@  void RkISP1CameraData::paramsComputed(unsigned int frame, unsigned int bytesused
 		selfPath_->queueBuffer(info->selfPathBuffer);
 }
 
-void RkISP1CameraData::setSensorControls([[maybe_unused]] unsigned int frame,
+void RkISP1CameraData::setSensorControls(unsigned int frame,
 					 const ControlList &sensorControls)
 {
-	delayedCtrls_->push(sensorControls);
+	delayedCtrls_->push(frame, sensorControls);
 }
 
 void RkISP1CameraData::metadataReady(unsigned int frame, const ControlList &metadata)