[v3] ipa: simple: Initialize ccmEnabled to false
diff mbox series

Message ID 20250402073133.15710-1-stanislaw.gruszka@linux.intel.com
State Accepted
Headers show
Series
  • [v3] ipa: simple: Initialize ccmEnabled to false
Related show

Commit Message

Stanislaw Gruszka April 2, 2025, 7:31 a.m. UTC 
ccmEnabled variable is not initialized by default, which results in
usage of CCM when the algorithm itself is not enabled and configured.

The bug manifests itself as seldom reproducible corrupted video stream.
Fix by initialize ccmEnabled member where it is declared.

Reviewed-by: Milan Zamazal <mzamazal@redhat.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Fixes: ac3068655643 ("libcamera: software_isp: Track whether CCM is enabled")
Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
---
v2 -> v3:
 - update changelog
v1 -> v2:
 - initialize on declaration 
 - fix spelling

 src/ipa/simple/ipa_context.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch
diff mbox series 

diff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h
index 7dc2cd7ae828..51522720ab98 100644
--- a/src/ipa/simple/ipa_context.h
+++ b/src/ipa/simple/ipa_context.h
@@ -91,7 +91,7 @@  struct IPAContext {
 	IPAActiveState activeState;
 	FCQueue<IPAFrameContext> frameContexts;
 	ControlInfoMap::Map ctrlMap;
-	bool ccmEnabled;
+	bool ccmEnabled = false;
 };
 
 } /* namespace ipa::soft */