| Message ID | 20250401141455.492231-1-stanislaw.gruszka@linux.intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
On Tue, Apr 01, 2025 at 04:14:55PM +0200, Stanislaw Gruszka wrote: > ccmEnabled variable is not initialized by default, which results in > usage of CCM when the algorithm itself is not enabled and configured. > > The bug manifests itself as seldom reproducible corrupted video stream. > Fix by initialize the variable in IPAContext class initialization list. Forgot to fix "initialization list" here, will post v3 > Reviewed-by: Milan Zamazal <mzamazal@redhat.com> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Fixes: ac3068655643 ("libcamera: software_isp: Track whether CCM is enabled") > Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com> > --- > v1 -> v2: > - initialize on declaration > - fix spelling > > src/ipa/simple/ipa_context.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h > index 7dc2cd7ae828..51522720ab98 100644 > --- a/src/ipa/simple/ipa_context.h > +++ b/src/ipa/simple/ipa_context.h > @@ -91,7 +91,7 @@ struct IPAContext { > IPAActiveState activeState; > FCQueue<IPAFrameContext> frameContexts; > ControlInfoMap::Map ctrlMap; > - bool ccmEnabled; > + bool ccmEnabled = false; > }; > > } /* namespace ipa::soft */ > -- > 2.43.0 >
diff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h index 7dc2cd7ae828..51522720ab98 100644 --- a/src/ipa/simple/ipa_context.h +++ b/src/ipa/simple/ipa_context.h @@ -91,7 +91,7 @@ struct IPAContext { IPAActiveState activeState; FCQueue<IPAFrameContext> frameContexts; ControlInfoMap::Map ctrlMap; - bool ccmEnabled; + bool ccmEnabled = false; }; } /* namespace ipa::soft */