[libcamera-devel,8/8] Documentation: theme: css: Really hide toc trees

Message ID 20191021102453.26471-8-laurent.pinchart@ideasonboard.com
State Accepted
Commit fb93dae7d3d3c7099b46e0a801e6bd1c4dc0366c
Headers show
Series
  • [libcamera-devel,1/8] Documentation: Move coding style under contributing
Related show

Commit Message

Laurent Pinchart Oct. 21, 2019, 10:24 a.m. UTC
The toc trees are rendered as hidden but still take space due to their
margin and padding. Really hide them. While at it, don't handle overflow
with scrollbars in the content area, the whole page should be
scrollable.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 Documentation/theme/static/css/theme.css | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Kieran Bingham Oct. 21, 2019, 11:10 a.m. UTC | #1
Hi Laurent,

On 21/10/2019 11:24, Laurent Pinchart wrote:
> The toc trees are rendered as hidden but still take space due to their
> margin and padding. Really hide them. While at it, don't handle overflow
> with scrollbars in the content area, the whole page should be
> scrollable.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Sounds good to me.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>


> ---
>  Documentation/theme/static/css/theme.css | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/theme/static/css/theme.css b/Documentation/theme/static/css/theme.css
> index 60f3510d88fa..a4934edeeb8f 100644
> --- a/Documentation/theme/static/css/theme.css
> +++ b/Documentation/theme/static/css/theme.css
> @@ -204,7 +204,6 @@ div#content {
>  	padding-bottom: 50px;
>  	margin-left: 0px;
>  	margin-right: 0px;
> -	overflow: auto;
>  }
>  
>  div#content > div.block {
> @@ -283,5 +282,8 @@ div#signature {
>  }
>  
>  #libcamera div.toctree-wrapper {
> +	height: 0px;
> +	margin: 0px;
> +	padding: 0px;
>  	visibility: hidden;
>  }
>

Patch

diff --git a/Documentation/theme/static/css/theme.css b/Documentation/theme/static/css/theme.css
index 60f3510d88fa..a4934edeeb8f 100644
--- a/Documentation/theme/static/css/theme.css
+++ b/Documentation/theme/static/css/theme.css
@@ -204,7 +204,6 @@  div#content {
 	padding-bottom: 50px;
 	margin-left: 0px;
 	margin-right: 0px;
-	overflow: auto;
 }
 
 div#content > div.block {
@@ -283,5 +282,8 @@  div#signature {
 }
 
 #libcamera div.toctree-wrapper {
+	height: 0px;
+	margin: 0px;
+	padding: 0px;
 	visibility: hidden;
 }