| Message ID | 20191021102453.26471-7-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | 09d7d00a0fbed8d2a944509e712242bab016a4ba |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, On 21/10/2019 11:24, Laurent Pinchart wrote: > The text is currently rendered as a 50% gray, which is a bit painful to > read in low light conditions. Make it darker. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Is 65% an arbitrary increase? Or just feels better when you compared? Anyway, no objections: Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > Documentation/theme/static/css/theme.css | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/Documentation/theme/static/css/theme.css b/Documentation/theme/static/css/theme.css > index 4901bbf564f7..60f3510d88fa 100644 > --- a/Documentation/theme/static/css/theme.css > +++ b/Documentation/theme/static/css/theme.css > @@ -6,7 +6,7 @@ html { > } > > body { > - color: rgb(0, 0, 0, 0.5); > + color: rgb(0, 0, 0, 0.65); > font-family: Arial, sans-serif; > margin: 0px; > } > @@ -217,7 +217,6 @@ div#content > div.block { > } > > div#content > div.block h1 { > - color: black; > font-size: 40px; > margin-top: 0px; > text-align: left; >
Hi Kieran, On Mon, Oct 21, 2019 at 12:08:59PM +0100, Kieran Bingham wrote: > On 21/10/2019 11:24, Laurent Pinchart wrote: > > The text is currently rendered as a 50% gray, which is a bit painful to > > read in low light conditions. Make it darker. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Is 65% an arbitrary increase? Or just feels better when you compared? It's a bit arbitrary, based on my personal feeling. Feel free to test it and provide a better value :-) > Anyway, no objections: > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > --- > > Documentation/theme/static/css/theme.css | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/Documentation/theme/static/css/theme.css b/Documentation/theme/static/css/theme.css > > index 4901bbf564f7..60f3510d88fa 100644 > > --- a/Documentation/theme/static/css/theme.css > > +++ b/Documentation/theme/static/css/theme.css > > @@ -6,7 +6,7 @@ html { > > } > > > > body { > > - color: rgb(0, 0, 0, 0.5); > > + color: rgb(0, 0, 0, 0.65); > > font-family: Arial, sans-serif; > > margin: 0px; > > } > > @@ -217,7 +217,6 @@ div#content > div.block { > > } > > > > div#content > div.block h1 { > > - color: black; > > font-size: 40px; > > margin-top: 0px; > > text-align: left;
On 21/10/2019 14:55, Laurent Pinchart wrote: > Hi Kieran, > > On Mon, Oct 21, 2019 at 12:08:59PM +0100, Kieran Bingham wrote: >> On 21/10/2019 11:24, Laurent Pinchart wrote: >>> The text is currently rendered as a 50% gray, which is a bit painful to >>> read in low light conditions. Make it darker. >>> >>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >> >> Is 65% an arbitrary increase? Or just feels better when you compared? > > It's a bit arbitrary, based on my personal feeling. Feel free to test it > and provide a better value :-) Ok - then 66% :D This is fine :-) >> Anyway, no objections: >> >> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> >> >>> --- >>> Documentation/theme/static/css/theme.css | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/Documentation/theme/static/css/theme.css b/Documentation/theme/static/css/theme.css >>> index 4901bbf564f7..60f3510d88fa 100644 >>> --- a/Documentation/theme/static/css/theme.css >>> +++ b/Documentation/theme/static/css/theme.css >>> @@ -6,7 +6,7 @@ html { >>> } >>> >>> body { >>> - color: rgb(0, 0, 0, 0.5); >>> + color: rgb(0, 0, 0, 0.65); >>> font-family: Arial, sans-serif; >>> margin: 0px; >>> } >>> @@ -217,7 +217,6 @@ div#content > div.block { >>> } >>> >>> div#content > div.block h1 { >>> - color: black; >>> font-size: 40px; >>> margin-top: 0px; >>> text-align: left; >
diff --git a/Documentation/theme/static/css/theme.css b/Documentation/theme/static/css/theme.css index 4901bbf564f7..60f3510d88fa 100644 --- a/Documentation/theme/static/css/theme.css +++ b/Documentation/theme/static/css/theme.css @@ -6,7 +6,7 @@ html { } body { - color: rgb(0, 0, 0, 0.5); + color: rgb(0, 0, 0, 0.65); font-family: Arial, sans-serif; margin: 0px; } @@ -217,7 +217,6 @@ div#content > div.block { } div#content > div.block h1 { - color: black; font-size: 40px; margin-top: 0px; text-align: left;
The text is currently rendered as a 50% gray, which is a bit painful to read in low light conditions. Make it darker. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- Documentation/theme/static/css/theme.css | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)