| Message ID | 20240613155949.1041061-5-dan.scally@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Quoting Daniel Scally (2024-06-13 16:59:46) > Initialise camera properties so that DNG files written by cam contain Well, I wouldn't call that the reason. I'd say it's to correctly initiliase the camera properties from the camera sensor class! But for the change, and with a clear commit message: Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > model information for the LSC tuning scripts. > > Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com> > --- > src/libcamera/pipeline/mali-c55/mali-c55.cpp | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp > index 2c34f3e9..2b1d766a 100644 > --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp > +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp > @@ -1099,8 +1099,7 @@ bool PipelineHandlerMaliC55::registerSensorCamera(MediaLink *ispLink) > if (data->init()) > return false; > > - /* \todo: Init properties. */ > - > + data->properties_ = data->sensor_->properties(); > data->updateControls(); > > registerMaliCamera(std::move(data), sensor->name()); > -- > 2.30.2 >
diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp index 2c34f3e9..2b1d766a 100644 --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp @@ -1099,8 +1099,7 @@ bool PipelineHandlerMaliC55::registerSensorCamera(MediaLink *ispLink) if (data->init()) return false; - /* \todo: Init properties. */ - + data->properties_ = data->sensor_->properties(); data->updateControls(); registerMaliCamera(std::move(data), sensor->name());
Initialise camera properties so that DNG files written by cam contain model information for the LSC tuning scripts. Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com> --- src/libcamera/pipeline/mali-c55/mali-c55.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)