| Message ID | 20240613155949.1041061-7-dan.scally@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Quoting Daniel Scally (2024-06-13 16:59:48) > The MaliC55CameraData::mbusCodes() function is unused. Remove it. > > Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com> Well, that's easy. Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/libcamera/pipeline/mali-c55/mali-c55.cpp | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp > index 910eac5e..9cd243a3 100644 > --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp > +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp > @@ -94,7 +94,6 @@ public: > int init(); > > /* Deflect these functionalities to either TPG or CameraSensor. */ > - const std::vector<unsigned int> mbusCodes() const; > const std::vector<Size> sizes(unsigned int mbusCode) const; > const Size resolution() const; > > @@ -179,14 +178,6 @@ void MaliC55CameraData::initTPGData() > tpgResolution_ = tpgSizes_.back(); > } > > -const std::vector<unsigned int> MaliC55CameraData::mbusCodes() const > -{ > - if (sensor_) > - return sensor_->mbusCodes(); > - > - return tpgCodes_; > -} > - > const std::vector<Size> MaliC55CameraData::sizes(unsigned int mbusCode) const > { > if (sensor_) > -- > 2.30.2 >
On Thu, Jun 13, 2024 at 08:37:03PM +0100, Kieran Bingham wrote: > Quoting Daniel Scally (2024-06-13 16:59:48) > > The MaliC55CameraData::mbusCodes() function is unused. Remove it. > > > > Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com> > > Well, that's easy. > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > src/libcamera/pipeline/mali-c55/mali-c55.cpp | 9 --------- > > 1 file changed, 9 deletions(-) > > > > diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp > > index 910eac5e..9cd243a3 100644 > > --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp > > +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp > > @@ -94,7 +94,6 @@ public: > > int init(); > > > > /* Deflect these functionalities to either TPG or CameraSensor. */ > > - const std::vector<unsigned int> mbusCodes() const; > > const std::vector<Size> sizes(unsigned int mbusCode) const; > > const Size resolution() const; > > > > @@ -179,14 +178,6 @@ void MaliC55CameraData::initTPGData() > > tpgResolution_ = tpgSizes_.back(); > > } > > > > -const std::vector<unsigned int> MaliC55CameraData::mbusCodes() const > > -{ > > - if (sensor_) > > - return sensor_->mbusCodes(); > > - > > - return tpgCodes_; > > -} > > - > > const std::vector<Size> MaliC55CameraData::sizes(unsigned int mbusCode) const > > { > > if (sensor_)
diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp index 910eac5e..9cd243a3 100644 --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp @@ -94,7 +94,6 @@ public: int init(); /* Deflect these functionalities to either TPG or CameraSensor. */ - const std::vector<unsigned int> mbusCodes() const; const std::vector<Size> sizes(unsigned int mbusCode) const; const Size resolution() const; @@ -179,14 +178,6 @@ void MaliC55CameraData::initTPGData() tpgResolution_ = tpgSizes_.back(); } -const std::vector<unsigned int> MaliC55CameraData::mbusCodes() const -{ - if (sensor_) - return sensor_->mbusCodes(); - - return tpgCodes_; -} - const std::vector<Size> MaliC55CameraData::sizes(unsigned int mbusCode) const { if (sensor_)
The MaliC55CameraData::mbusCodes() function is unused. Remove it. Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com> --- src/libcamera/pipeline/mali-c55/mali-c55.cpp | 9 --------- 1 file changed, 9 deletions(-)