[libcamera-devel,2/3] test: process: Initialise member variables
diff mbox series

Message ID 20190910090418.30502-3-kieran.bingham@ideasonboard.com
State Accepted
Commit 122892d1bccf0495579918a4fcdf74a793e9fb36
Headers show
Series
  • test: process: Cleanup to process test
Related show

Commit Message

Kieran Bingham Sept. 10, 2019, 9:04 a.m. UTC 
The ProcessTest() declares member variables but leaves them unitialised.
Set them appropriately from the constructor.

Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 test/process/process_test.cpp | 1 +
 1 file changed, 1 insertion(+)

Comments

Laurent Pinchart Sept. 10, 2019, 9:44 a.m. UTC | #1 
Hi Kieran,

Thank you for the patch.

On Tue, Sep 10, 2019 at 10:04:17AM +0100, Kieran Bingham wrote:
> The ProcessTest() declares member variables but leaves them unitialised.
> Set them appropriately from the constructor.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  test/process/process_test.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/test/process/process_test.cpp b/test/process/process_test.cpp
> index 701f156b5053..f3cabe0a36c7 100644
> --- a/test/process/process_test.cpp
> +++ b/test/process/process_test.cpp
> @@ -35,6 +35,7 @@ class ProcessTest : public Test
>  {
>  public:
>  	ProcessTest()
> +		: exitStatus_(Process::NotExited), exitCode_(-1)
>  	{
>  	}
>

Patch
diff mbox series 

diff --git a/test/process/process_test.cpp b/test/process/process_test.cpp
index 701f156b5053..f3cabe0a36c7 100644
--- a/test/process/process_test.cpp
+++ b/test/process/process_test.cpp
@@ -35,6 +35,7 @@  class ProcessTest : public Test
 {
 public:
 	ProcessTest()
+		: exitStatus_(Process::NotExited), exitCode_(-1)
 	{
 	}