[libcamera-devel,0/3] test: process: Cleanup to process test
mbox series

Message ID 20190910090418.30502-1-kieran.bingham@ideasonboard.com
Headers show
Series
  • test: process: Cleanup to process test
Related show

Message

Kieran Bingham Sept. 10, 2019, 9:04 a.m. UTC 
While developing the serialisation implementation - I found I was frequently
hitting failures on the Process test.

The occurence of both successful runs and failed runs suggests uninitialised
data and lost races.

These three cleanups fix two potential races and ensures that the member
variables in the test are correctly initialised.

Correct initialisation of the exitStatus_ is then used to provide an earliest
opportunity shutdown of the test with it's extended timeout.

Kieran Bingham (3):
  test: process: Fix forking race
  test: process: Initialise member variables
  test: process: Extend timeout duration

 test/process/process_test.cpp | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comments

Kieran Bingham Sept. 13, 2019, 8:28 a.m. UTC | #1 
Series pushed to master with "test: process: Fix forking race" retitled,
and reworded.
--
Kieran


On 10/09/2019 10:04, Kieran Bingham wrote:
> While developing the serialisation implementation - I found I was frequently
> hitting failures on the Process test.
> 
> The occurence of both successful runs and failed runs suggests uninitialised
> data and lost races.
> 
> These three cleanups fix two potential races and ensures that the member
> variables in the test are correctly initialised.
> 
> Correct initialisation of the exitStatus_ is then used to provide an earliest
> opportunity shutdown of the test with it's extended timeout.
> 
> Kieran Bingham (3):
>   test: process: Fix forking race
>   test: process: Initialise member variables
>   test: process: Extend timeout duration
> 
>  test/process/process_test.cpp | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>