| Message ID | 20240121224052.1049989-4-neal@gompa.dev |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Neal, Thank you for the patch. On Sun, Jan 21, 2024 at 05:39:55PM -0500, Neal Gompa via libcamera-devel wrote: > The documentation is effectively the same, but we should be pointing > to the actively supported and used Qt version. > > Signed-off-by: Neal Gompa <neal@gompa.dev> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> I'll merge this quickly, without waiting for 1/3. > --- > Documentation/guides/application-developer.rst | 2 +- > Documentation/guides/pipeline-handler.rst | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst > index c46d3362..9a9905b1 100644 > --- a/Documentation/guides/application-developer.rst > +++ b/Documentation/guides/application-developer.rst > @@ -348,7 +348,7 @@ The libcamera library uses the concept of `signals and slots` (similar to `Qt > Signals and Slots`_) to connect events with callbacks to handle them. > > .. _signals and slots: https://libcamera.org/api-html/classlibcamera_1_1Signal.html#details > -.. _Qt Signals and Slots: https://doc.qt.io/qt-5/signalsandslots.html > +.. _Qt Signals and Slots: https://doc.qt.io/qt-6/signalsandslots.html > > The ``Camera`` device emits two signals that applications can connect to in > order to execute callbacks on frame completion events. > diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst > index 26dc9358..2046a2e7 100644 > --- a/Documentation/guides/pipeline-handler.rst > +++ b/Documentation/guides/pipeline-handler.rst > @@ -1422,7 +1422,7 @@ emitted triggers the execution of the connected slots. A detailed description > of the libcamera implementation is available in the `libcamera Signal and Slot`_ > classes documentation. > > -.. _Qt Signals and Slots: https://doc.qt.io/qt-5/signalsandslots.html > +.. _Qt Signals and Slots: https://doc.qt.io/qt-6/signalsandslots.html > .. _libcamera Signal and Slot: https://libcamera.org/api-html/classlibcamera_1_1Signal.html#details > > In order to notify applications about the availability of new frames and data,
On Sun, 21 Jan 2024 at 22:41, Neal Gompa <neal@gompa.dev> wrote: > > The documentation is effectively the same, but we should be pointing > to the actively supported and used Qt version. > > Signed-off-by: Neal Gompa <neal@gompa.dev> Reviewed-by: Eric Curtin <ecurtin@redhat.com> Is mise le meas/Regards, Eric Curtin > --- > Documentation/guides/application-developer.rst | 2 +- > Documentation/guides/pipeline-handler.rst | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst > index c46d3362..9a9905b1 100644 > --- a/Documentation/guides/application-developer.rst > +++ b/Documentation/guides/application-developer.rst > @@ -348,7 +348,7 @@ The libcamera library uses the concept of `signals and slots` (similar to `Qt > Signals and Slots`_) to connect events with callbacks to handle them. > > .. _signals and slots: https://libcamera.org/api-html/classlibcamera_1_1Signal.html#details > -.. _Qt Signals and Slots: https://doc.qt.io/qt-5/signalsandslots.html > +.. _Qt Signals and Slots: https://doc.qt.io/qt-6/signalsandslots.html > > The ``Camera`` device emits two signals that applications can connect to in > order to execute callbacks on frame completion events. > diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst > index 26dc9358..2046a2e7 100644 > --- a/Documentation/guides/pipeline-handler.rst > +++ b/Documentation/guides/pipeline-handler.rst > @@ -1422,7 +1422,7 @@ emitted triggers the execution of the connected slots. A detailed description > of the libcamera implementation is available in the `libcamera Signal and Slot`_ > classes documentation. > > -.. _Qt Signals and Slots: https://doc.qt.io/qt-5/signalsandslots.html > +.. _Qt Signals and Slots: https://doc.qt.io/qt-6/signalsandslots.html > .. _libcamera Signal and Slot: https://libcamera.org/api-html/classlibcamera_1_1Signal.html#details > > In order to notify applications about the availability of new frames and data, > -- > 2.43.0 >
diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst index c46d3362..9a9905b1 100644 --- a/Documentation/guides/application-developer.rst +++ b/Documentation/guides/application-developer.rst @@ -348,7 +348,7 @@ The libcamera library uses the concept of `signals and slots` (similar to `Qt Signals and Slots`_) to connect events with callbacks to handle them. .. _signals and slots: https://libcamera.org/api-html/classlibcamera_1_1Signal.html#details -.. _Qt Signals and Slots: https://doc.qt.io/qt-5/signalsandslots.html +.. _Qt Signals and Slots: https://doc.qt.io/qt-6/signalsandslots.html The ``Camera`` device emits two signals that applications can connect to in order to execute callbacks on frame completion events. diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst index 26dc9358..2046a2e7 100644 --- a/Documentation/guides/pipeline-handler.rst +++ b/Documentation/guides/pipeline-handler.rst @@ -1422,7 +1422,7 @@ emitted triggers the execution of the connected slots. A detailed description of the libcamera implementation is available in the `libcamera Signal and Slot`_ classes documentation. -.. _Qt Signals and Slots: https://doc.qt.io/qt-5/signalsandslots.html +.. _Qt Signals and Slots: https://doc.qt.io/qt-6/signalsandslots.html .. _libcamera Signal and Slot: https://libcamera.org/api-html/classlibcamera_1_1Signal.html#details In order to notify applications about the availability of new frames and data,
The documentation is effectively the same, but we should be pointing to the actively supported and used Qt version. Signed-off-by: Neal Gompa <neal@gompa.dev> --- Documentation/guides/application-developer.rst | 2 +- Documentation/guides/pipeline-handler.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)