[libcamera-devel,v2,0/3] apps: qcam: Port to Qt 6
mbox series

Message ID 20240121224052.1049989-1-neal@gompa.dev
Headers show
Series
  • apps: qcam: Port to Qt 6
Related show

Message

Neal Gompa Jan. 21, 2024, 10:39 p.m. UTC
Open source Qt 5 has been effectively end of life since the release
of Qt 6, and Qt 6 has current LTS releases now.

This change ports qcam to Qt 6.2 and drops some of the baggage related
to Qt 5 that is no longer applicable.

Additionally, a couple of patches are included to update documentation
references from Qt 5 to Qt 6.

=== Changelog ===

v2: Bump Meson to v0.63 for Qt6 module

v1: Initial patch set

Neal Gompa (3):
  apps: qcam: Port to Qt 6
  libcamera: base: signal: Update Qt documentation link to Qt 6
  Documentation: Update Qt documentation links to Qt 6

 .../guides/application-developer.rst          |  2 +-
 Documentation/guides/pipeline-handler.rst     |  2 +-
 README.rst                                    |  2 +-
 meson.build                                   |  2 +-
 src/apps/qcam/meson.build                     | 45 ++++++-------------
 src/libcamera/base/signal.cpp                 |  2 +-
 6 files changed, 18 insertions(+), 37 deletions(-)

Comments

Laurent Pinchart Jan. 22, 2024, 7:40 a.m. UTC | #1
Hi Neal,

Thank you for the patch.

On Sun, Jan 21, 2024 at 05:39:52PM -0500, Neal Gompa via libcamera-devel wrote:
> Open source Qt 5 has been effectively end of life since the release
> of Qt 6, and Qt 6 has current LTS releases now.
> 
> This change ports qcam to Qt 6.2 and drops some of the baggage related
> to Qt 5 that is no longer applicable.
> 
> Additionally, a couple of patches are included to update documentation
> references from Qt 5 to Qt 6.

I'll give this a try, I'm currently installing Qt 6, which is taking a
bit of time as I'm running Gentoo :-) It seems that Debian bookworm and
bullseye-backports both carry Qt 6, so we should be fine from that point
of view.

> === Changelog ===
> 
> v2: Bump Meson to v0.63 for Qt6 module
> 
> v1: Initial patch set
> 
> Neal Gompa (3):
>   apps: qcam: Port to Qt 6
>   libcamera: base: signal: Update Qt documentation link to Qt 6
>   Documentation: Update Qt documentation links to Qt 6
> 
>  .../guides/application-developer.rst          |  2 +-
>  Documentation/guides/pipeline-handler.rst     |  2 +-
>  README.rst                                    |  2 +-
>  meson.build                                   |  2 +-
>  src/apps/qcam/meson.build                     | 45 ++++++-------------
>  src/libcamera/base/signal.cpp                 |  2 +-
>  6 files changed, 18 insertions(+), 37 deletions(-)
Laurent Pinchart Jan. 22, 2024, 9:52 a.m. UTC | #2
On Mon, Jan 22, 2024 at 09:40:01AM +0200, Laurent Pinchart via libcamera-devel wrote:
> On Sun, Jan 21, 2024 at 05:39:52PM -0500, Neal Gompa via libcamera-devel wrote:
> > Open source Qt 5 has been effectively end of life since the release
> > of Qt 6, and Qt 6 has current LTS releases now.
> > 
> > This change ports qcam to Qt 6.2 and drops some of the baggage related
> > to Qt 5 that is no longer applicable.
> > 
> > Additionally, a couple of patches are included to update documentation
> > references from Qt 5 to Qt 6.
> 
> I'll give this a try, I'm currently installing Qt 6, which is taking a
> bit of time as I'm running Gentoo :-) It seems that Debian bookworm and
> bullseye-backports both carry Qt 6, so we should be fine from that point
> of view.

I gave this a quick try on Gentoo, and qcam seems to compile and run. It
is however not displaying icons in the toolbar. Have you noticed that ?

> > === Changelog ===
> > 
> > v2: Bump Meson to v0.63 for Qt6 module
> > 
> > v1: Initial patch set
> > 
> > Neal Gompa (3):
> >   apps: qcam: Port to Qt 6
> >   libcamera: base: signal: Update Qt documentation link to Qt 6
> >   Documentation: Update Qt documentation links to Qt 6
> > 
> >  .../guides/application-developer.rst          |  2 +-
> >  Documentation/guides/pipeline-handler.rst     |  2 +-
> >  README.rst                                    |  2 +-
> >  meson.build                                   |  2 +-
> >  src/apps/qcam/meson.build                     | 45 ++++++-------------
> >  src/libcamera/base/signal.cpp                 |  2 +-
> >  6 files changed, 18 insertions(+), 37 deletions(-)