| Message ID | 20240104151548.2589-3-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes: > If an error occurs there's no point in ignoring it silently and > continuing. Exit immediately. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Milan Zamazal <mzamazal@redhat.com> > --- > utils/update-mojo.sh | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/utils/update-mojo.sh b/utils/update-mojo.sh > index 967d139a3f70..831f5ab8753b 100755 > --- a/utils/update-mojo.sh > +++ b/utils/update-mojo.sh > @@ -3,6 +3,8 @@ > # SPDX-License-Identifier: GPL-2.0-or-later > # Update mojo copy from a chromium source tree > > +set -e > + > if [ $# != 1 ] ; then > echo "Usage: $0 <chromium dir>" > exit 1
Quoting Laurent Pinchart via libcamera-devel (2024-01-04 15:15:42) > If an error occurs there's no point in ignoring it silently and > continuing. Exit immediately. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > utils/update-mojo.sh | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/utils/update-mojo.sh b/utils/update-mojo.sh > index 967d139a3f70..831f5ab8753b 100755 > --- a/utils/update-mojo.sh > +++ b/utils/update-mojo.sh > @@ -3,6 +3,8 @@ > # SPDX-License-Identifier: GPL-2.0-or-later > # Update mojo copy from a chromium source tree > > +set -e > + > if [ $# != 1 ] ; then > echo "Usage: $0 <chromium dir>" > exit 1 > -- > Regards, > > Laurent Pinchart >
diff --git a/utils/update-mojo.sh b/utils/update-mojo.sh index 967d139a3f70..831f5ab8753b 100755 --- a/utils/update-mojo.sh +++ b/utils/update-mojo.sh @@ -3,6 +3,8 @@ # SPDX-License-Identifier: GPL-2.0-or-later # Update mojo copy from a chromium source tree +set -e + if [ $# != 1 ] ; then echo "Usage: $0 <chromium dir>" exit 1
If an error occurs there's no point in ignoring it silently and continuing. Exit immediately. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- utils/update-mojo.sh | 2 ++ 1 file changed, 2 insertions(+)