| Message ID | 20231206210524.20974-6-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | efcda47985cbb631418449a57f3ade80ca12f8cb |
| Headers | show |
| Series |
|
| Related | show |
Le mercredi 06 décembre 2023 à 23:05 +0200, Laurent Pinchart a écrit : > When running tests on slower devices, 200ms is too low to wait for the > process to exit. Increase the timeout to 2s. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> > --- > test/ipc/unixsocket.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/ipc/unixsocket.cpp b/test/ipc/unixsocket.cpp > index 304e613bc984..1d4df28726cd 100644 > --- a/test/ipc/unixsocket.cpp > +++ b/test/ipc/unixsocket.cpp > @@ -431,7 +431,7 @@ private: > if (ret) > return ret; > > - timeout.start(200ms); > + timeout.start(2s); > while (!callDone_) { > if (!timeout.isRunning()) { > cerr << "Call timeout!" << endl;
Hi Nicolas, On Wed, Dec 06, 2023 at 04:10:30PM -0500, Nicolas Dufresne wrote: > Le mercredi 06 décembre 2023 à 23:05 +0200, Laurent Pinchart a écrit : > > When running tests on slower devices, 200ms is too low to wait for the > > process to exit. Increase the timeout to 2s. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> Thanks for the review. I made a mistake though, I meant to CC you (and Vedant and Umang) on patch 6/6, not 5/6. Sorry about that. > > --- > > test/ipc/unixsocket.cpp | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/test/ipc/unixsocket.cpp b/test/ipc/unixsocket.cpp > > index 304e613bc984..1d4df28726cd 100644 > > --- a/test/ipc/unixsocket.cpp > > +++ b/test/ipc/unixsocket.cpp > > @@ -431,7 +431,7 @@ private: > > if (ret) > > return ret; > > > > - timeout.start(200ms); > > + timeout.start(2s); > > while (!callDone_) { > > if (!timeout.isRunning()) { > > cerr << "Call timeout!" << endl;
Le mercredi 06 décembre 2023 à 23:19 +0200, Laurent Pinchart a écrit : > Hi Nicolas, > > On Wed, Dec 06, 2023 at 04:10:30PM -0500, Nicolas Dufresne wrote: > > Le mercredi 06 décembre 2023 à 23:05 +0200, Laurent Pinchart a écrit : > > > When running tests on slower devices, 200ms is too low to wait for the > > > process to exit. Increase the timeout to 2s. > > > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> > > Thanks for the review. I made a mistake though, I meant to CC you (and > Vedant and Umang) on patch 6/6, not 5/6. Sorry about that. That explains, I thought is was a bit trivial of a change to ask me and Vedant for a review. regards, Nicolas > > > > --- > > > test/ipc/unixsocket.cpp | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/test/ipc/unixsocket.cpp b/test/ipc/unixsocket.cpp > > > index 304e613bc984..1d4df28726cd 100644 > > > --- a/test/ipc/unixsocket.cpp > > > +++ b/test/ipc/unixsocket.cpp > > > @@ -431,7 +431,7 @@ private: > > > if (ret) > > > return ret; > > > > > > - timeout.start(200ms); > > > + timeout.start(2s); > > > while (!callDone_) { > > > if (!timeout.isRunning()) { > > > cerr << "Call timeout!" << endl; >
Quoting Laurent Pinchart via libcamera-devel (2023-12-06 21:05:23) > When running tests on slower devices, 200ms is too low to wait for the > process to exit. Increase the timeout to 2s. > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > test/ipc/unixsocket.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/ipc/unixsocket.cpp b/test/ipc/unixsocket.cpp > index 304e613bc984..1d4df28726cd 100644 > --- a/test/ipc/unixsocket.cpp > +++ b/test/ipc/unixsocket.cpp > @@ -431,7 +431,7 @@ private: > if (ret) > return ret; > > - timeout.start(200ms); > + timeout.start(2s); > while (!callDone_) { > if (!timeout.isRunning()) { > cerr << "Call timeout!" << endl; > -- > Regards, > > Laurent Pinchart >
diff --git a/test/ipc/unixsocket.cpp b/test/ipc/unixsocket.cpp index 304e613bc984..1d4df28726cd 100644 --- a/test/ipc/unixsocket.cpp +++ b/test/ipc/unixsocket.cpp @@ -431,7 +431,7 @@ private: if (ret) return ret; - timeout.start(200ms); + timeout.start(2s); while (!callDone_) { if (!timeout.isRunning()) { cerr << "Call timeout!" << endl;
When running tests on slower devices, 200ms is too low to wait for the process to exit. Increase the timeout to 2s. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- test/ipc/unixsocket.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)