[libcamera-devel,4/6] test: log: log_process: Increase process exit timeout
diff mbox series

Message ID 20231206210524.20974-5-laurent.pinchart@ideasonboard.com
State Accepted
Commit 9dc2642d2c9cfac4c738ee46229958f7c7c85a16
Headers show
Series
  • test: Miscellaneous fixes and improvements for unit tests
Related show

Commit Message

Laurent Pinchart Dec. 6, 2023, 9:05 p.m. UTC 
When running tests on slower devices, 200ms is too low to wait for the
process to exit. Increase the timeout to 2s.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 test/log/log_process.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kieran Bingham Dec. 7, 2023, 4:29 p.m. UTC | #1 
Quoting Laurent Pinchart via libcamera-devel (2023-12-06 21:05:22)
> When running tests on slower devices, 200ms is too low to wait for the
> process to exit. Increase the timeout to 2s.


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  test/log/log_process.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/log/log_process.cpp b/test/log/log_process.cpp
> index fb6635cc99aa..1926c56039b6 100644
> --- a/test/log/log_process.cpp
> +++ b/test/log/log_process.cpp
> @@ -81,7 +81,7 @@ protected:
>                         return TestFail;
>                 }
>  
> -               timeout.start(200ms);
> +               timeout.start(2s);
>                 while (timeout.isRunning())
>                         dispatcher->processEvents();
>  
> -- 
> Regards,
> 
> Laurent Pinchart
>
Umang Jain Dec. 8, 2023, 7:12 a.m. UTC | #2 
Hi Laurent,

On 12/7/23 2:35 AM, Laurent Pinchart via libcamera-devel wrote:
> When running tests on slower devices, 200ms is too low to wait for the
> process to exit. Increase the timeout to 2s.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>

> ---
>   test/log/log_process.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/log/log_process.cpp b/test/log/log_process.cpp
> index fb6635cc99aa..1926c56039b6 100644
> --- a/test/log/log_process.cpp
> +++ b/test/log/log_process.cpp
> @@ -81,7 +81,7 @@ protected:
>   			return TestFail;
>   		}
>   
> -		timeout.start(200ms);
> +		timeout.start(2s);
>   		while (timeout.isRunning())
>   			dispatcher->processEvents();
>

Patch
diff mbox series 

diff --git a/test/log/log_process.cpp b/test/log/log_process.cpp
index fb6635cc99aa..1926c56039b6 100644
--- a/test/log/log_process.cpp
+++ b/test/log/log_process.cpp
@@ -81,7 +81,7 @@  protected:
 			return TestFail;
 		}
 
-		timeout.start(200ms);
+		timeout.start(2s);
 		while (timeout.isRunning())
 			dispatcher->processEvents();