| Message ID | 20230606-alphabetical-order-v2-1-50869c0f9215@skidata.com |
|---|---|
| State | Accepted |
| Commit | 0a37c203da58b3c23c011d8233c16c6063e3cb86 |
| Headers | show |
| Series |
|
| Related | show |
Hi Benjamin, Thank you for the patch. On Tue, Jun 06, 2023 at 04:27:11PM +0200, Benjamin Bara wrote: > From: Benjamin Bara <benjamin.bara@skidata.com> > > The addition of the CameraSensorHelperImx327 class was not correctly > inserted in alphabetical sort order. > > Move it to the correct location. > > Fixes: 7d5b38e2ef41 ("libipa: camera_sensor_helper: Add IMX327 helper") > Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Benjamin Bara <benjamin.bara@skidata.com> > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > Unfortunately missed to keep the alphabetical order as mentioned by > Laurent. No worries, that happens :-) > --- > Changes in v2: > - Add commit message > - Link to v1: https://lists.libcamera.org/pipermail/libcamera-devel/2023-June/038129.html > --- > src/ipa/libipa/camera_sensor_helper.cpp | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp > index 2eebd7ab..f0ecc383 100644 > --- a/src/ipa/libipa/camera_sensor_helper.cpp > +++ b/src/ipa/libipa/camera_sensor_helper.cpp > @@ -428,11 +428,6 @@ public: > }; > REGISTER_CAMERA_SENSOR_HELPER("imx290", CameraSensorHelperImx290) > > -class CameraSensorHelperImx327 : public CameraSensorHelperImx290 > -{ > -}; > -REGISTER_CAMERA_SENSOR_HELPER("imx327", CameraSensorHelperImx327) > - > class CameraSensorHelperImx296 : public CameraSensorHelper > { > public: > @@ -444,6 +439,11 @@ public: > }; > REGISTER_CAMERA_SENSOR_HELPER("imx296", CameraSensorHelperImx296) > > +class CameraSensorHelperImx327 : public CameraSensorHelperImx290 > +{ > +}; > +REGISTER_CAMERA_SENSOR_HELPER("imx327", CameraSensorHelperImx327) > + > class CameraSensorHelperImx477 : public CameraSensorHelper > { > public: > > --- > base-commit: a0271e72a86da5796891795565f43f20f7024a8d > change-id: 20230606-alphabetical-order-ea13b8e95f1e
diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index 2eebd7ab..f0ecc383 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -428,11 +428,6 @@ public: }; REGISTER_CAMERA_SENSOR_HELPER("imx290", CameraSensorHelperImx290) -class CameraSensorHelperImx327 : public CameraSensorHelperImx290 -{ -}; -REGISTER_CAMERA_SENSOR_HELPER("imx327", CameraSensorHelperImx327) - class CameraSensorHelperImx296 : public CameraSensorHelper { public: @@ -444,6 +439,11 @@ public: }; REGISTER_CAMERA_SENSOR_HELPER("imx296", CameraSensorHelperImx296) +class CameraSensorHelperImx327 : public CameraSensorHelperImx290 +{ +}; +REGISTER_CAMERA_SENSOR_HELPER("imx327", CameraSensorHelperImx327) + class CameraSensorHelperImx477 : public CameraSensorHelper { public: