| Message ID | 20230119155905.464995-2-mike.rudenko@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Mikhail On Thu, Jan 19, 2023 at 06:59:02PM +0300, Mikhail Rudenko via libcamera-devel wrote: > Add support for Omnivision OV4689 image sensor to libipa. > > The sensor implements a linear gain equation with analogue gain > control values 0-2047 corresponding to 0x-16x physical gain range. > > Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com> Thanks for abstracting it nicely in the driver Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Thanks j > --- > src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp > index 3d8a2835..075c568e 100644 > --- a/src/ipa/libipa/camera_sensor_helper.cpp > +++ b/src/ipa/libipa/camera_sensor_helper.cpp > @@ -461,6 +461,17 @@ public: > }; > REGISTER_CAMERA_SENSOR_HELPER("ov2740", CameraSensorHelperOv2740) > > +class CameraSensorHelperOv4689 : public CameraSensorHelper > +{ > +public: > + CameraSensorHelperOv4689() > + { > + gainType_ = AnalogueGainLinear; > + gainConstants_.linear = { 1, 0, 0, 128 }; > + } > +}; > +REGISTER_CAMERA_SENSOR_HELPER("ov4689", CameraSensorHelperOv4689) > + > class CameraSensorHelperOv5640 : public CameraSensorHelper > { > public: > -- > 2.39.0 >
diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index 3d8a2835..075c568e 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -461,6 +461,17 @@ public: }; REGISTER_CAMERA_SENSOR_HELPER("ov2740", CameraSensorHelperOv2740) +class CameraSensorHelperOv4689 : public CameraSensorHelper +{ +public: + CameraSensorHelperOv4689() + { + gainType_ = AnalogueGainLinear; + gainConstants_.linear = { 1, 0, 0, 128 }; + } +}; +REGISTER_CAMERA_SENSOR_HELPER("ov4689", CameraSensorHelperOv4689) + class CameraSensorHelperOv5640 : public CameraSensorHelper { public:
Add support for Omnivision OV4689 image sensor to libipa. The sensor implements a linear gain equation with analogue gain control values 0-2047 corresponding to 0x-16x physical gain range. Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com> --- src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++ 1 file changed, 11 insertions(+)