| Message ID | 20230118085953.7027-7-naush@raspberrypi.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Quoting Naushir Patuck via libcamera-devel (2023-01-18 08:59:47) > Add a pipeline_data_dir variable to the meson build files. This variable > points to the location of pipeline handler specific configuration files on > the filesystem. > Sounds reasonable. Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> > --- > src/libcamera/pipeline/meson.build | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/libcamera/pipeline/meson.build b/src/libcamera/pipeline/meson.build > index 30dc5b97f1dc..f14869f3a3c0 100644 > --- a/src/libcamera/pipeline/meson.build > +++ b/src/libcamera/pipeline/meson.build > @@ -1,5 +1,8 @@ > # SPDX-License-Identifier: CC0-1.0 > > +# Location of pipeline specific configuration files > +pipeline_data_dir = libcamera_datadir / 'pipeline' > + > foreach pipeline : pipelines > subdir(pipeline) > endforeach > -- > 2.25.1 >
Hi Naush, Thank you for the patch. On Wed, Jan 18, 2023 at 08:59:47AM +0000, Naushir Patuck via libcamera-devel wrote: > Add a pipeline_data_dir variable to the meson build files. This variable > points to the location of pipeline handler specific configuration files on > the filesystem. I'm curious to know which text editor you use to write commit messages, as I thought the most common ones wrap lines to 72 characters by default :-) > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> > --- > src/libcamera/pipeline/meson.build | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/libcamera/pipeline/meson.build b/src/libcamera/pipeline/meson.build > index 30dc5b97f1dc..f14869f3a3c0 100644 > --- a/src/libcamera/pipeline/meson.build > +++ b/src/libcamera/pipeline/meson.build > @@ -1,5 +1,8 @@ > # SPDX-License-Identifier: CC0-1.0 > > +# Location of pipeline specific configuration files > +pipeline_data_dir = libcamera_datadir / 'pipeline' > + I wonder if we should later move this variable within the loop, and append the pipeline handler name automatically. It will help ensuring consistency, but I'm pretty sure that, as soon as we would merge a patch, someone would have a valid use case for an exception :-) Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > foreach pipeline : pipelines > subdir(pipeline) > endforeach
diff --git a/src/libcamera/pipeline/meson.build b/src/libcamera/pipeline/meson.build index 30dc5b97f1dc..f14869f3a3c0 100644 --- a/src/libcamera/pipeline/meson.build +++ b/src/libcamera/pipeline/meson.build @@ -1,5 +1,8 @@ # SPDX-License-Identifier: CC0-1.0 +# Location of pipeline specific configuration files +pipeline_data_dir = libcamera_datadir / 'pipeline' + foreach pipeline : pipelines subdir(pipeline) endforeach
Add a pipeline_data_dir variable to the meson build files. This variable points to the location of pipeline handler specific configuration files on the filesystem. Signed-off-by: Naushir Patuck <naush@raspberrypi.com> --- src/libcamera/pipeline/meson.build | 3 +++ 1 file changed, 3 insertions(+)