| Message ID | 20221006195523.17739-1-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | 7465ee8e0cc10babbebb2124b15abb1dd8f21983 |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, Thank you for the patch On 10/7/22 1:25 AM, Laurent Pinchart via libcamera-devel wrote: > The CameraManager::get() function takes a string containing the ID of > the requested camera. This is correctly documented and implemented in > the .cpp file, but the header file names the parameter 'name' instead of > 'id'. Fix it. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com> > --- > include/libcamera/camera_manager.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/libcamera/camera_manager.h b/include/libcamera/camera_manager.h > index 7647c2a1c43c..4b1fb7568e83 100644 > --- a/include/libcamera/camera_manager.h > +++ b/include/libcamera/camera_manager.h > @@ -31,7 +31,7 @@ public: > void stop(); > > std::vector<std::shared_ptr<Camera>> cameras() const; > - std::shared_ptr<Camera> get(const std::string &name); > + std::shared_ptr<Camera> get(const std::string &id); > std::shared_ptr<Camera> get(dev_t devnum); > > void addCamera(std::shared_ptr<Camera> camera,
diff --git a/include/libcamera/camera_manager.h b/include/libcamera/camera_manager.h index 7647c2a1c43c..4b1fb7568e83 100644 --- a/include/libcamera/camera_manager.h +++ b/include/libcamera/camera_manager.h @@ -31,7 +31,7 @@ public: void stop(); std::vector<std::shared_ptr<Camera>> cameras() const; - std::shared_ptr<Camera> get(const std::string &name); + std::shared_ptr<Camera> get(const std::string &id); std::shared_ptr<Camera> get(dev_t devnum); void addCamera(std::shared_ptr<Camera> camera,
The CameraManager::get() function takes a string containing the ID of the requested camera. This is correctly documented and implemented in the .cpp file, but the header file names the parameter 'name' instead of 'id'. Fix it. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- include/libcamera/camera_manager.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)