[libcamera-devel,v4,15/32] ipa: rkisp1: Use base FrameContext class
diff mbox series

Message ID 20220908014200.28728-16-laurent.pinchart@ideasonboard.com
State Superseded
Headers show
Series
  • ipa: Frame context queue, IPU3 & RkISP consolidation, and RkISP1 improvements
Related show

Commit Message

Laurent Pinchart Sept. 8, 2022, 1:41 a.m. UTC 
Inherit from the base FrameContext class in the RkISP1 IPAFrameContext.
As the IPAFrameContext is currently unused, this change is a no-op, but
it prepares the RkISP1 IPA module for frame context queue support.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/ipa/rkisp1/ipa_context.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Kieran Bingham Sept. 20, 2022, 2:46 p.m. UTC | #1 
Quoting Laurent Pinchart via libcamera-devel (2022-09-08 02:41:43)
> Inherit from the base FrameContext class in the RkISP1 IPAFrameContext.
> As the IPAFrameContext is currently unused, this change is a no-op, but
> it prepares the RkISP1 IPA module for frame context queue support.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/ipa/rkisp1/ipa_context.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h
> index 5590482c6a8c..f6b3e6eb951c 100644
> --- a/src/ipa/rkisp1/ipa_context.h
> +++ b/src/ipa/rkisp1/ipa_context.h
> @@ -14,6 +14,8 @@
>  
>  #include <libcamera/geometry.h>
>  
> +#include <libipa/fc_queue.h>
> +
>  namespace libcamera {
>  
>  namespace ipa::rkisp1 {
> @@ -89,7 +91,7 @@ struct IPAActiveState {
>         unsigned int frameCount;
>  };
>  
> -struct IPAFrameContext {
> +struct IPAFrameContext : public FrameContext {
>  };
>  
>  struct IPAContext {
> -- 
> Regards,
> 
> Laurent Pinchart
>
Jacopo Mondi Sept. 21, 2022, 6:35 p.m. UTC | #2 
Can't argue :)

Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>

Thanks
   j

On Thu, Sep 08, 2022 at 04:41:43AM +0300, Laurent Pinchart via libcamera-devel wrote:
> Inherit from the base FrameContext class in the RkISP1 IPAFrameContext.
> As the IPAFrameContext is currently unused, this change is a no-op, but
> it prepares the RkISP1 IPA module for frame context queue support.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  src/ipa/rkisp1/ipa_context.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h
> index 5590482c6a8c..f6b3e6eb951c 100644
> --- a/src/ipa/rkisp1/ipa_context.h
> +++ b/src/ipa/rkisp1/ipa_context.h
> @@ -14,6 +14,8 @@
>
>  #include <libcamera/geometry.h>
>
> +#include <libipa/fc_queue.h>
> +
>  namespace libcamera {
>
>  namespace ipa::rkisp1 {
> @@ -89,7 +91,7 @@ struct IPAActiveState {
>  	unsigned int frameCount;
>  };
>
> -struct IPAFrameContext {
> +struct IPAFrameContext : public FrameContext {
>  };
>
>  struct IPAContext {
> --
> Regards,
>
> Laurent Pinchart
>

Patch
diff mbox series 

diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h
index 5590482c6a8c..f6b3e6eb951c 100644
--- a/src/ipa/rkisp1/ipa_context.h
+++ b/src/ipa/rkisp1/ipa_context.h
@@ -14,6 +14,8 @@ 
 
 #include <libcamera/geometry.h>
 
+#include <libipa/fc_queue.h>
+
 namespace libcamera {
 
 namespace ipa::rkisp1 {
@@ -89,7 +91,7 @@  struct IPAActiveState {
 	unsigned int frameCount;
 };
 
-struct IPAFrameContext {
+struct IPAFrameContext : public FrameContext {
 };
 
 struct IPAContext {