| Message ID | 20220908014200.28728-13-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Quoting Laurent Pinchart via libcamera-devel (2022-09-08 02:41:40) > From: Jacopo Mondi <jacopo@jmondi.org> > > The "autoExposure" class member is not used. > > Remove it. Well that's easy. Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > --- > src/ipa/rkisp1/rkisp1.cpp | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp > index 07210d16b5b5..f7a17459b6c3 100644 > --- a/src/ipa/rkisp1/rkisp1.cpp > +++ b/src/ipa/rkisp1/rkisp1.cpp > @@ -71,9 +71,6 @@ private: > > ControlInfoMap ctrls_; > > - /* Camera sensor controls. */ > - bool autoExposure_; > - > /* revision-specific data */ > rkisp1_cif_isp_version hwRevision_; > unsigned int hwHistBinNMax_; > @@ -216,8 +213,6 @@ int IPARkISP1::configure([[maybe_unused]] const IPACameraSensorInfo &info, > return -EINVAL; > } > > - autoExposure_ = true; > - > int32_t minExposure = itExp->second.min().get<int32_t>(); > int32_t maxExposure = itExp->second.max().get<int32_t>(); > > -- > Regards, > > Laurent Pinchart >
diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp index 07210d16b5b5..f7a17459b6c3 100644 --- a/src/ipa/rkisp1/rkisp1.cpp +++ b/src/ipa/rkisp1/rkisp1.cpp @@ -71,9 +71,6 @@ private: ControlInfoMap ctrls_; - /* Camera sensor controls. */ - bool autoExposure_; - /* revision-specific data */ rkisp1_cif_isp_version hwRevision_; unsigned int hwHistBinNMax_; @@ -216,8 +213,6 @@ int IPARkISP1::configure([[maybe_unused]] const IPACameraSensorInfo &info, return -EINVAL; } - autoExposure_ = true; - int32_t minExposure = itExp->second.min().get<int32_t>(); int32_t maxExposure = itExp->second.max().get<int32_t>();