[libcamera-devel,2/5] libcamera: Make openssl and gnutls dependencies recommended
diff mbox series

Message ID 20220807021456.9578-3-laurent.pinchart@ideasonboard.com
State Superseded
Headers show
Series
  • libcamera: Support openssl as an alternative to gnutls
Related show

Commit Message

Laurent Pinchart Aug. 7, 2022, 2:14 a.m. UTC 
While gnutls and openssl are not strictly required, the overheard
introduced by isolating all IPA modules when signatures are not
available is better avoided. Document the dependencies as recommended,
and warn at meson setup time if they are not found.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 README.rst                | 5 ++++-
 src/libcamera/meson.build | 2 ++
 src/meson.build           | 1 +
 3 files changed, 7 insertions(+), 1 deletion(-)

Patch
diff mbox series 

diff --git a/README.rst b/README.rst
index ffecd5bc6552..3606057ff706 100644
--- a/README.rst
+++ b/README.rst
@@ -60,9 +60,12 @@  Meson Build system: [required]
 for the libcamera core: [required]
         libyaml-dev python3-yaml python3-ply python3-jinja2
 
-for IPA module signing: [optional]
+for IPA module signing: [recommended]
         libgnutls28-dev openssl
 
+        Without IPA module signing, all IPA modules will be isolated in a
+        separate process. This adds an unnecessary extra overhead at runtime.
+
 for improved debugging: [optional]
         libdw-dev libunwind-dev
 
diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
index ff0e31ebcb63..8580feed3846 100644
--- a/src/libcamera/meson.build
+++ b/src/libcamera/meson.build
@@ -71,6 +71,8 @@  libyaml = dependency('yaml-0.1', required : false)
 
 if libgnutls.found()
     config_h.set('HAVE_GNUTLS', 1)
+else
+    warning('gnutls not found, all IPA modules will be isolated')
 endif
 
 if liblttng.found()
diff --git a/src/meson.build b/src/meson.build
index 65276fc74606..f37c44ca9f60 100644
--- a/src/meson.build
+++ b/src/meson.build
@@ -22,6 +22,7 @@  if openssl.found()
     config_h.set('HAVE_IPA_PUBKEY', 1)
     ipa_sign_module = true
 else
+    warning('openssl not found, all IPA modules will be isolated')
     ipa_sign_module = false
 endif