From patchwork Sun Aug 7 02:14:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 17000 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 846A3BE173 for ; Sun, 7 Aug 2022 02:15:11 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3BC9863325; Sun, 7 Aug 2022 04:15:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1659838511; bh=iIXeeXIsd33gPVe0oayvWNkGb8tVCGWRS4H28lKPXvo=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=wMl0DEx/KKfc5xjoG2vUOjevb5L+D7H7OK//Vu0g97ERSSGoMlz2zu52PjsfDrnRs Hd5cLcR5gmv5asnA6V+AgudiBjl9klRBXKq2L+kcC/XtBp5HikIUXUXPpIs1igyU8L kFveworXWVie0LjJFO/vH9TXyJqaEcYZHPL5Wv3bAIbcOWwSFfvifVhUNh1fBTH0wa 4Zm7Zcns2Hw8Y7KcW3wPVYhCpobIzfFFKPyoRKPJ7lnofJLewK9lnHABP6bI2a1dZf TyPX5tcZ5biod1FvZ6Eo4MMUJapF28f02DeV7QZhPCjeOGNlh7OxOkJlY7M+6s/84c 2/JuQ834ZKFdQ== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9573263325 for ; Sun, 7 Aug 2022 04:15:08 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Lx9yVZzb"; dkim-atps=neutral Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2FEF356D for ; Sun, 7 Aug 2022 04:15:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1659838508; bh=iIXeeXIsd33gPVe0oayvWNkGb8tVCGWRS4H28lKPXvo=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Lx9yVZzbgtyDL7pS3EYDUSqBDI6xCRuKVlOx8JhHMaUkS1ZDlZhzkIzH5eXAP/X+5 5QlTf0Tp8m15dwJ0stOFNJtKKSOjYFHA8WKTKwPshsOECWAO9XcyHqsySnLH+nlBaf J1PLAUNVlbAYV8JEr+7pGHABftKz+3Bkoa1ZwX+o= To: libcamera-devel@lists.libcamera.org Date: Sun, 7 Aug 2022 05:14:53 +0300 Message-Id: <20220807021456.9578-3-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220807021456.9578-1-laurent.pinchart@ideasonboard.com> References: <20220807021456.9578-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/5] libcamera: Make openssl and gnutls dependencies recommended X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" While gnutls and openssl are not strictly required, the overheard introduced by isolating all IPA modules when signatures are not available is better avoided. Document the dependencies as recommended, and warn at meson setup time if they are not found. Signed-off-by: Laurent Pinchart --- README.rst | 5 ++++- src/libcamera/meson.build | 2 ++ src/meson.build | 1 + 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/README.rst b/README.rst index ffecd5bc6552..3606057ff706 100644 --- a/README.rst +++ b/README.rst @@ -60,9 +60,12 @@ Meson Build system: [required] for the libcamera core: [required] libyaml-dev python3-yaml python3-ply python3-jinja2 -for IPA module signing: [optional] +for IPA module signing: [recommended] libgnutls28-dev openssl + Without IPA module signing, all IPA modules will be isolated in a + separate process. This adds an unnecessary extra overhead at runtime. + for improved debugging: [optional] libdw-dev libunwind-dev diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build index ff0e31ebcb63..8580feed3846 100644 --- a/src/libcamera/meson.build +++ b/src/libcamera/meson.build @@ -71,6 +71,8 @@ libyaml = dependency('yaml-0.1', required : false) if libgnutls.found() config_h.set('HAVE_GNUTLS', 1) +else + warning('gnutls not found, all IPA modules will be isolated') endif if liblttng.found() diff --git a/src/meson.build b/src/meson.build index 65276fc74606..f37c44ca9f60 100644 --- a/src/meson.build +++ b/src/meson.build @@ -22,6 +22,7 @@ if openssl.found() config_h.set('HAVE_IPA_PUBKEY', 1) ipa_sign_module = true else + warning('openssl not found, all IPA modules will be isolated') ipa_sign_module = false endif