[libcamera-devel,v3,07/18] py: unittests: make typechecker happy
diff mbox series

Message ID 20220518131329.66994-8-tomi.valkeinen@ideasonboard.com
State Accepted
Headers show
Series
  • Misc Python bindings patches
Related show

Commit Message

Tomi Valkeinen May 18, 2022, 1:13 p.m. UTC 
Add some annotations and self.assertIsNotNone() calls to remove the
typechecker warnings.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 test/py/unittests.py | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

Patch
diff mbox series 

diff --git a/test/py/unittests.py b/test/py/unittests.py
index 4c214f0a..7dede33b 100755
--- a/test/py/unittests.py
+++ b/test/py/unittests.py
@@ -10,6 +10,7 @@  import libcamera as libcam
 import os
 import selectors
 import time
+import typing
 import unittest
 import weakref
 
@@ -70,6 +71,9 @@  class SimpleTestMethods(BaseTestCase):
 
 
 class CameraTesterBase(BaseTestCase):
+    cm: typing.Any
+    cam: typing.Any
+
     def setUp(self):
         self.cm = libcam.CameraManager.singleton()
         self.cam = next((cam for cam in self.cm.cameras if 'platform/vimc' in cam.id), None)
@@ -131,6 +135,7 @@  class AllocatorTestMethods(CameraTesterBase):
         wr_allocator = weakref.ref(allocator)
 
         buffers = allocator.buffers(stream)
+        self.assertIsNotNone(buffers)
         buffers = None
 
         buffer = allocator.buffers(stream)[0]
@@ -166,6 +171,8 @@  class SimpleCaptureMethods(CameraTesterBase):
 
         streamconfig = camconfig.at(0)
         fmts = streamconfig.formats
+        self.assertIsNotNone(fmts)
+        fmts = None
 
         ret = cam.configure(camconfig)
         self.assertZero(ret)
@@ -225,6 +232,8 @@  class SimpleCaptureMethods(CameraTesterBase):
 
         streamconfig = camconfig.at(0)
         fmts = streamconfig.formats
+        self.assertIsNotNone(fmts)
+        fmts = None
 
         ret = cam.configure(camconfig)
         self.assertZero(ret)
@@ -348,9 +357,9 @@  if __name__ == '__main__':
         gc.unfreeze()
         gc.collect()
 
-        obs_after = get_all_objects([obs_before])
+        obs_after = get_all_objects([obs_before])   # type: ignore
 
-        before = create_type_count_map(obs_before)
+        before = create_type_count_map(obs_before)  # type: ignore
         after = create_type_count_map(obs_after)
 
         leaks = diff_type_count_maps(before, after)