[libcamera-devel,v3,03/18] py: add comment about the symlinks
diff mbox series

Message ID 20220518131329.66994-4-tomi.valkeinen@ideasonboard.com
State Accepted
Headers show
Series
  • Misc Python bindings patches
Related show

Commit Message

Tomi Valkeinen May 18, 2022, 1:13 p.m. UTC 
Add comment about the symlinks to clarify the purpose.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
---
 src/py/libcamera/meson.build | 3 +++
 1 file changed, 3 insertions(+)

Comments

Laurent Pinchart May 18, 2022, 1:42 p.m. UTC | #1 
Hi Tomi,

Thank you for the patch.

On Wed, May 18, 2022 at 04:13:14PM +0300, Tomi Valkeinen wrote:
> Add comment about the symlinks to clarify the purpose.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/py/libcamera/meson.build | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build
> index 3c0828b8..427716d7 100644
> --- a/src/py/libcamera/meson.build
> +++ b/src/py/libcamera/meson.build
> @@ -54,6 +54,9 @@ pycamera = shared_module('_libcamera',
>                           dependencies : pycamera_deps,
>                           cpp_args : pycamera_args)
>  
> +# Create symlinks from the build dir to the source dir so that we can use the
> +# Python module directly from the build dir.
> +
>  run_command('ln', '-fsT', files('__init__.py'),
>              meson.current_build_dir() / '__init__.py',
>              check: true)
Kieran Bingham May 18, 2022, 2:08 p.m. UTC | #2 
Quoting Tomi Valkeinen (2022-05-18 14:13:14)
> Add comment about the symlinks to clarify the purpose.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/py/libcamera/meson.build | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build
> index 3c0828b8..427716d7 100644
> --- a/src/py/libcamera/meson.build
> +++ b/src/py/libcamera/meson.build
> @@ -54,6 +54,9 @@ pycamera = shared_module('_libcamera',
>                           dependencies : pycamera_deps,
>                           cpp_args : pycamera_args)
>  
> +# Create symlinks from the build dir to the source dir so that we can use the
> +# Python module directly from the build dir.
> +
>  run_command('ln', '-fsT', files('__init__.py'),
>              meson.current_build_dir() / '__init__.py',
>              check: true)
> -- 
> 2.34.1
>

Patch
diff mbox series 

diff --git a/src/py/libcamera/meson.build b/src/py/libcamera/meson.build
index 3c0828b8..427716d7 100644
--- a/src/py/libcamera/meson.build
+++ b/src/py/libcamera/meson.build
@@ -54,6 +54,9 @@  pycamera = shared_module('_libcamera',
                          dependencies : pycamera_deps,
                          cpp_args : pycamera_args)
 
+# Create symlinks from the build dir to the source dir so that we can use the
+# Python module directly from the build dir.
+
 run_command('ln', '-fsT', files('__init__.py'),
             meson.current_build_dir() / '__init__.py',
             check: true)