[libcamera-devel,RFC,v1,3/5] ipa: ipu3: Variables to hold the maximum VCM steps
diff mbox series

Message ID 20220414074342.7455-4-hpa@redhat.com
State Superseded
Headers show
Series
  • Enabling AF algorithm to get the VCM attributes from the device driver
Related show

Commit Message

Kate Hsuan April 14, 2022, 7:43 a.m. UTC
They are used to place the maximum VCM steps.

Signed-off-by: Kate Hsuan<hpa@redhat.com>
---
 include/libcamera/ipa/core.mojom | 2 ++
 src/ipa/ipu3/ipa_context.h       | 1 +
 2 files changed, 3 insertions(+)

Comments

Kieran Bingham April 14, 2022, 9 a.m. UTC | #1
Quoting Kate Hsuan via libcamera-devel (2022-04-14 08:43:40)
> They are used to place the maximum VCM steps.
> 
> Signed-off-by: Kate Hsuan<hpa@redhat.com>
> ---
>  include/libcamera/ipa/core.mojom | 2 ++
>  src/ipa/ipu3/ipa_context.h       | 1 +
>  2 files changed, 3 insertions(+)
> 
> diff --git a/include/libcamera/ipa/core.mojom b/include/libcamera/ipa/core.mojom
> index 74f3339e..5378ec0c 100644
> --- a/include/libcamera/ipa/core.mojom
> +++ b/include/libcamera/ipa/core.mojom
> @@ -221,6 +221,8 @@ struct IPACameraSensorInfo {
>  
>         uint32 minFrameLength;
>         uint32 maxFrameLength;
> +
> +       uint32 maxVcmSteps;
>  };
>  
>  /**
> diff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h
> index 103498ef..3b8aa621 100644
> --- a/src/ipa/ipu3/ipa_context.h
> +++ b/src/ipa/ipu3/ipa_context.h
> @@ -27,6 +27,7 @@ struct IPASessionConfiguration {
>  
>         struct {
>                 ipu3_uapi_grid_config afGrid;
> +               int32_t maxVcmSteps;

uint32_t, but the field may not be needed anyway.

>         } af;
>  
>         struct {
> -- 
> 2.35.1
>

Patch
diff mbox series

diff --git a/include/libcamera/ipa/core.mojom b/include/libcamera/ipa/core.mojom
index 74f3339e..5378ec0c 100644
--- a/include/libcamera/ipa/core.mojom
+++ b/include/libcamera/ipa/core.mojom
@@ -221,6 +221,8 @@  struct IPACameraSensorInfo {
 
 	uint32 minFrameLength;
 	uint32 maxFrameLength;
+
+	uint32 maxVcmSteps;
 };
 
 /**
diff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h
index 103498ef..3b8aa621 100644
--- a/src/ipa/ipu3/ipa_context.h
+++ b/src/ipa/ipu3/ipa_context.h
@@ -27,6 +27,7 @@  struct IPASessionConfiguration {
 
 	struct {
 		ipu3_uapi_grid_config afGrid;
+		int32_t maxVcmSteps;
 	} af;
 
 	struct {