[libcamera-devel,1/2] controls: Add HotPixelMode
diff mbox series

Message ID 20211221053304.2704780-2-paul.elder@ideasonboard.com
State New
Delegated to: Paul Elder
Headers show
Series
  • android: Hot pixel correction
Related show

Commit Message

Paul Elder Dec. 21, 2021, 5:33 a.m. UTC 
Add a control for setting and reporting the operating mode for hot pixel
correction.

Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
---
 src/libcamera/control_ids.yaml | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

Patch
diff mbox series 

diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml
index 411200a8..44f785e2 100644
--- a/src/libcamera/control_ids.yaml
+++ b/src/libcamera/control_ids.yaml
@@ -925,6 +925,34 @@  controls:
           value: 3
           description: The AWB algorithm is locked.
 
+  - HotPixelMode:
+      type: int32_t
+      draft: true
+      description: |
+        Control to set and report the operation mode for hot pixel correction.
+
+        Hot pixel correction interpolates out, or otherwise removes, pixels
+        that do not accurately measure the incoming light (i.e. pixels that are
+        stuck at an arbitrary value or are oversensitive).
+
+        \todo Return the hot pixel map.
+      enum:
+        - name: HotPixelModeOff
+          value: 0
+          description: |
+            No hot pixel correction is applied. The frame rate must not be
+            reduced relative to sensor raw output.
+        - name: HotPixelModeFast
+          value: 1
+          description: |
+            Hot pixel correction is applied, without reducing frame rate
+            relative to sensor raw output.
+        - name: HotPixelModeHighQuality
+          value: 2
+          description: |
+            Hot pixel correction is applied, at a cost of possibly reduced
+            frame rate relative to sensor raw output.
+
   - SensorRollingShutterSkew:
       type: int64_t
       draft: true