From patchwork Tue Dec 21 05:33:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 15204 X-Patchwork-Delegate: paul.elder@ideasonboard.com Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 846A3BE080 for ; Tue, 21 Dec 2021 05:33:15 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A104060901; Tue, 21 Dec 2021 06:33:14 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="WgZUsAjz"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 30CF0608EB for ; Tue, 21 Dec 2021 06:33:13 +0100 (CET) Received: from pyrite.mediacom.info (unknown [IPv6:2604:2d80:ad90:fb00:96fd:8874:873:6c16]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 62401FD2; Tue, 21 Dec 2021 06:33:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1640064792; bh=Gj3hqLPq6Vs1gN+PjmFsLy+0u9LQ00ZI2D5o3wqKPu0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WgZUsAjzUieTxRG+O90mGCCUimNMtatzuFvKEs0wwr2XTpgbeHY6LJhnpFc5IvuLS a5JpZnWqsutRBHjop2+7Bl4l+yT5ofqHdclDVVSwypBlk3zafpB68KhoQvS3SDxUcV r9ZPkmlasBoZAyZ2jRdOioy+1Lcfj0r0sPcKb6hI= From: Paul Elder To: libcamera-devel@lists.libcamera.org Date: Mon, 20 Dec 2021 23:33:03 -0600 Message-Id: <20211221053304.2704780-2-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20211221053304.2704780-1-paul.elder@ideasonboard.com> References: <20211221053304.2704780-1-paul.elder@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 1/2] controls: Add HotPixelMode X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add a control for setting and reporting the operating mode for hot pixel correction. Signed-off-by: Paul Elder --- src/libcamera/control_ids.yaml | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml index 411200a8..44f785e2 100644 --- a/src/libcamera/control_ids.yaml +++ b/src/libcamera/control_ids.yaml @@ -925,6 +925,34 @@ controls: value: 3 description: The AWB algorithm is locked. + - HotPixelMode: + type: int32_t + draft: true + description: | + Control to set and report the operation mode for hot pixel correction. + + Hot pixel correction interpolates out, or otherwise removes, pixels + that do not accurately measure the incoming light (i.e. pixels that are + stuck at an arbitrary value or are oversensitive). + + \todo Return the hot pixel map. + enum: + - name: HotPixelModeOff + value: 0 + description: | + No hot pixel correction is applied. The frame rate must not be + reduced relative to sensor raw output. + - name: HotPixelModeFast + value: 1 + description: | + Hot pixel correction is applied, without reducing frame rate + relative to sensor raw output. + - name: HotPixelModeHighQuality + value: 2 + description: | + Hot pixel correction is applied, at a cost of possibly reduced + frame rate relative to sensor raw output. + - SensorRollingShutterSkew: type: int64_t draft: true