[libcamera-devel,v5,01/11] libcamera: Print Timer identifier
diff mbox series

Message ID 20211210205239.354901-2-jacopo@jmondi.org
State Superseded
Headers show
Series
  • libcamera: Add fence
Related show

Commit Message

Jacopo Mondi Dec. 10, 2021, 8:52 p.m. UTC 
The Timer debug output does not report to which timer a condition refers
to. Fix that by printing the Timer address.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/libcamera/base/event_dispatcher_poll.cpp | 3 ++-
 src/libcamera/base/timer.cpp                 | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

Patch
diff mbox series 

diff --git a/src/libcamera/base/event_dispatcher_poll.cpp b/src/libcamera/base/event_dispatcher_poll.cpp
index 8ee22d5adcc4..7238a3165da8 100644
--- a/src/libcamera/base/event_dispatcher_poll.cpp
+++ b/src/libcamera/base/event_dispatcher_poll.cpp
@@ -214,7 +214,8 @@  int EventDispatcherPoll::poll(std::vector<struct pollfd> *pollfds)
 			timeout = { 0, 0 };
 
 		LOG(Event, Debug)
-			<< "timeout " << timeout.tv_sec << "."
+			<< "next timer " << nextTimer << " expires in "
+			<< timeout.tv_sec << "."
 			<< std::setfill('0') << std::setw(9)
 			<< timeout.tv_nsec;
 	}
diff --git a/src/libcamera/base/timer.cpp b/src/libcamera/base/timer.cpp
index 9c54352d46bd..187336e3a1a4 100644
--- a/src/libcamera/base/timer.cpp
+++ b/src/libcamera/base/timer.cpp
@@ -96,7 +96,7 @@  void Timer::start(std::chrono::milliseconds duration)
 void Timer::start(std::chrono::steady_clock::time_point deadline)
 {
 	if (Thread::current() != thread()) {
-		LOG(Timer, Error) << "Timer can't be started from another thread";
+		LOG(Timer, Error) << "Timer " << this << " << can't be started from another thread";
 		return;
 	}
 
@@ -128,7 +128,7 @@  void Timer::stop()
 		return;
 
 	if (Thread::current() != thread()) {
-		LOG(Timer, Error) << "Timer can't be stopped from another thread";
+		LOG(Timer, Error) << "Timer " << this << " can't be stopped from another thread";
 		return;
 	}